Add embedding to video dataset #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt-embedding-generator-video-method
…g-8204-video-embedding-model-implement-embedding-generator-video-method-embed-manger
…g-8204-video-embedding-model-implement-embedding-generator-video-method-embed-manger
…g-8204-video-embedding-model-implement-embedding-generator-video-method
…g-8204-video-embedding-model-implement-embedding-generator-pe-gen
…g-8204-video-embedding-model-implement-embedding-generator-pe-gen-video
…g-8204-video-embedding-model-implement-embedding-generator-pe-gen-video
…nt-embedding-generator-pe-gen-video
…g-8206-video-embedding-model-add-embedding-to-video-dataset
…g-8206-video-embedding-model-add-embedding-to-video-dataset
michal-lightly
requested changes
Dec 10, 2025
Contributor
michal-lightly
left a comment
michal-lightly
left a comment
There was a problem hiding this comment.
Thanks! Left some comments.
lightly_studio/src/lightly_studio/api/routes/api/text_embedding.py
Outdated
Show resolved
Hide resolved
lightly_studio/src/lightly_studio/api/routes/api/text_embedding.py
Outdated
Show resolved
Hide resolved
michal-lightly
approved these changes
Dec 11, 2025
…edding-to-video-dataset
JonasWurst
deleted the
jonas-lig-8206-video-embedding-model-add-embedding-to-video-dataset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed and why?
This adds the embedding execution to the video dataset creation.
How has it been tested?
unit tests. local testing.
Did you update CHANGELOG.md?