Skip to content

Commit

Permalink
docker related notes
Browse files Browse the repository at this point in the history
  • Loading branch information
carueda committed Aug 4, 2024
1 parent 21c9a8d commit 8fb066c
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/release-docker.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
###############################################################
# **NOTE** - dockerization has more recently been happening
# in other repos (pbp-jupyter, pbp-binder, ...).
# TODO revisit this at some point.
###############################################################

name: Build and publish docker images

on:
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ RUN apt-get update && apt-get install -y libsox-fmt-all libsox-dev

# Note: tentative adjustments
RUN /opt/conda/bin/conda install jupyter -y --quiet
RUN pip install mbari-pbp==1.0.11
RUN pip install mbari-pbp==1.1.0

ENV PYTHONPATH /opt/pbp:/opt/pbp/pbp
EXPOSE 8899
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile-minimal
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ FROM quay.io/jupyter/minimal-notebook:latest

WORKDIR /opt/pbp

RUN pip install mbari-pbp==1.0.11
RUN pip install mbari-pbp==1.1.0

USER root
RUN apt-get update && apt-get install -y libsox-fmt-all libsox-dev
Expand Down
2 changes: 1 addition & 1 deletion justfile
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ run-docker-for-notebooks dir='notebooks':
##############
# package build/publishing:

# A convenient recipe for development
# Build and publish package
publish:
poetry publish --build

Expand Down

0 comments on commit 8fb066c

Please sign in to comment.