chore(jquery-form): prepare to release jquery-form under named scope #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So if somebody installs the named-scope version of the package, they can tell by inspection where to look up the source code from which it was built.
|
Simple enough to merge. To make sure all this works I need to try releasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our first release is going to be
@liferay/jquery-formv3.51.0-liferay.1, and is going to correspond to the same code as upstream, but with the patch originally proposed in liferay-frontend/liferay-portal#699 applied to it. I'll send a separate PR for that in a minute. Subsequent releases, if any, will be@liferay/jquery-formv3.51.0-liferay.2, v3.51.0-liferay.3 etc. ie. the same versioning scheme we employ in liferay-ckeditor — the idea is that you can see at a glance what upstream version we're using as a base, and on top of that you can tell how many patches/tweaks we've applied on top.