fix(@clay/css): LPD-46380 Labels in dropdown-item are slightly misaligned #5917
+44
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋
The result is quite close to what we wanted. As I've detected, I'm not sure if we can adjust these pixels up or down. In addition, I guess the tick icon and the flag would be readjusted based on the changes. However, keeping the texts on the same baseline would be nice. Thanks! |
|
@drakonux I think I got it to align how you wanted? This is with the new update.
|
pat270
force-pushed
the
LPD-46380
branch
2 times, most recently
from
ddde6ee to
0b842eb
Compare
|
Let's go with these new changes! Thanks @pat270 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-46380
@veroglez I sent this as a separate pr. I think this fixed the issue? It's really hard for me to tell. Lmk if this isn't correct.
This is related to #5914