Handle connection errors in AcceptTermsModal #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hexnickk4997
previously approved these changes
Nov 6, 2023
packages/connect-wallet-modal/src/components/WalletsModal/components/AcceptTermsModal.tsx
Outdated
Show resolved
Hide resolved
packages/connect-wallet-modal/src/components/WalletsModal/components/AcceptTermsModal.tsx
Show resolved
Hide resolved
alx-khramov
force-pushed
the
fix/autoconnect-terms-handle-errors
branch
from
2bbbd25 to
a9487be
Compare
hexnickk4997
previously approved these changes
Nov 13, 2023
Jeday
previously approved these changes
Nov 14, 2023
alx-khramov
force-pushed
the
fix/autoconnect-terms-handle-errors
branch
from
3d49f68 to
66ab6af
Compare
Jeday
previously approved these changes
Nov 15, 2023
alx-khramov
force-pushed
the
fix/autoconnect-terms-handle-errors
branch
from
66ab6af to
d5b2fa2
Compare
Jeday
approved these changes
Nov 20, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves UI-1024
Problem
There was no handling of connection errors in case of the "Confirm connection" modal with the terms acceptance checkbox during a wallet autoconnection. This PR adds errors handling.
This code is going to be completely refactored after removing web3-react and autoconnection rework.