Updated sweep calculation #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madlabman
force-pushed
the
electra-sweep
branch
3 times, most recently
from
70897c6 to
d0cf8f4
Compare
madlabman
force-pushed
the
electra-sweep
branch
from
d0cf8f4 to
1725e61
Compare
madlabman
force-pushed
the
electra-sweep
branch
from
1725e61 to
5d3d2d2
Compare
madlabman
force-pushed
the
electra-sweep
branch
2 times, most recently
from
fb335f7 to
0160038
Compare
madlabman
force-pushed
the
electra-sweep
branch
from
0160038 to
8e089b3
Compare
madlabman
force-pushed
the
electra-sweep
branch
from
74b8b8e to
41e6a6f
Compare
F4ever
reviewed
Dec 24, 2024
F4ever
reviewed
Dec 24, 2024
hweawer
approved these changes
Jan 8, 2025
F4ever
reviewed
Jan 10, 2025
F4ever
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thing to consider: the spec-like logic is heavy, but has almost the same results as the current approach with no pending withdrawals; pending withdrawals have meaningful effect when there are thousands of them which doesn't seem to me as a case for mainnet.
It seems the old algo has an error due to rounding down via
int().Next steps: I would decide to go or not to go with the new algo. From my perspective it's better to abandon it and use the old approach with an updated multiplier to cover the case with pending withdrawals.