[EPIC] stVaults #874

tamtamchik · 2024-11-17T05:22:06Z

❗ 🚧 Under construction 🚧 ❗

Staking Vaults

New way of isolated staking, through separate vaults, with optional stETH liquidity

Support minting external backed stETH in Lido contract
Extract protocol accounting to separate contract (two-step, better precision)
StakingVault + VaultHub
Dashboard
VaultFactory
OperatorGrid
PredepositGuarantee
LazyOracle

TheDZhon

👀

.github/workflows/analyse.yml

.github/workflows/coverage.yml

.github/workflows/tests-integration-holesky-devnet-0.yml

.github/workflows/tests-integration-mainnet.yml

contracts/0.4.24/Lido.sol

github-advanced-security

Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

github-actions · 2024-11-27T10:36:53Z

Hardhat Unit Tests Coverage Summary

Filename                                                                Stmts    Miss  Cover    Missing
--------------------------------------------------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
contracts/0.4.24/Lido.sol                                                 240      12  95.00%   769-787, 867-879, 1007-1008
contracts/0.4.24/StETH.sol                                                 82       0  100.00%
contracts/0.4.24/StETHPermit.sol                                           15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                         5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                                       36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                                   37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                            435       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                         9       0  100.00%
contracts/0.4.24/utils/UnstructuredStorageUint128.sol                      14       1  92.86%   49
contracts/0.4.24/utils/Versioned.sol                                        5       0  100.00%
contracts/0.6.12/WstETH.sol                                                17       0  100.00%
contracts/0.8.25/ValidatorExitDelayVerifier.sol                            64       0  100.00%
contracts/0.8.25/utils/AccessControlConfirmable.sol                         2       0  100.00%
contracts/0.8.25/utils/Confirmable2Addresses.sol                            5       0  100.00%
contracts/0.8.25/utils/Confirmations.sol                                   37       0  100.00%
contracts/0.8.25/utils/PausableUntilWithRoles.sol                           3       0  100.00%
contracts/0.8.25/vaults/LazyOracle.sol                                     84      67  20.24%   144-145, 155-226, 262-360, 371-379, 389-393
contracts/0.8.25/vaults/OperatorGrid.sol                                  149       0  100.00%
contracts/0.8.25/vaults/PinnedBeaconProxy.sol                               5       0  100.00%
contracts/0.8.25/vaults/StakingVault.sol                                   98       0  100.00%
contracts/0.8.25/vaults/ValidatorConsolidationRequests.sol                 56       2  96.43%   100, 187
contracts/0.8.25/vaults/VaultFactory.sol                                   30       0  100.00%
contracts/0.8.25/vaults/VaultHub.sol                                      391     168  57.03%   231-232, 245-262, 274-308, 321-329, 416-479, 535-536, 573-670, 693-712, 749-758, 775-870, 893-944, 1015, 1089, 1118-1126, 1154, 1275, 1281-1282, 1402, 1410-1424, 1438-1442, 1473-1476, 1517, 1529
contracts/0.8.25/vaults/dashboard/Dashboard.sol                           120       0  100.00%
contracts/0.8.25/vaults/dashboard/NodeOperatorFee.sol                      70       0  100.00%
contracts/0.8.25/vaults/dashboard/Permissions.sol                          50       0  100.00%
contracts/0.8.25/vaults/interfaces/IPredepositGuarantee.sol                 0       0  100.00%
contracts/0.8.25/vaults/interfaces/IStakingVault.sol                        0       0  100.00%
contracts/0.8.25/vaults/lib/PinnedBeaconUtils.sol                           6       0  100.00%
contracts/0.8.25/vaults/lib/RefSlotCache.sol                               22      17  22.73%   31-42, 60-61, 77-97
contracts/0.8.25/vaults/predeposit_guarantee/CLProofVerifier.sol           16       1  93.75%   214
contracts/0.8.25/vaults/predeposit_guarantee/MeIfNobodyElse.sol             3       0  100.00%
contracts/0.8.25/vaults/predeposit_guarantee/PredepositGuarantee.sol      159       0  100.00%
contracts/0.8.9/Accounting.sol                                             83       2  97.59%   297-298
contracts/0.8.9/BeaconChainDepositor.sol                                   21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                                 92       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                                 128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                            16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                         16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                            26       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                                     28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                         305       0  100.00%
contracts/0.8.9/TriggerableWithdrawalsGateway.sol                          54       1  98.15%   274
contracts/0.8.9/WithdrawalQueue.sol                                        88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                                   146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                                  89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                                        32       0  100.00%
contracts/0.8.9/WithdrawalVaultEIP7002.sol                                 21       0  100.00%
contracts/0.8.9/lib/ExitLimitUtils.sol                                     31       0  100.00%
contracts/0.8.9/lib/Math.sol                                                4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                         22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                              2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                               173       2  98.84%   123-124
contracts/0.8.9/oracle/BaseOracle.sol                                      89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                                  263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBus.sol                              136      10  92.65%   440-453, 516
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                         53       1  98.11%   232
contracts/0.8.9/proxy/OssifiableProxy.sol                                  17       0  100.00%
contracts/0.8.9/proxy/WithdrawalsManagerProxy.sol                          60       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol               216       1  99.54%   860
contracts/0.8.9/utils/DummyEmptyContract.sol                                0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                                    31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                                        11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                             23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol                    9       0  100.00%
contracts/common/utils/PausableUntil.sol                                   29       0  100.00%
TOTAL                                                                    4579     289  93.69%

Diff against master

Filename                                                                Stmts    Miss  Cover
--------------------------------------------------------------------  -------  ------  --------
contracts/0.4.24/Lido.sol                                                 +28     +12  -5.00%
contracts/0.4.24/StETH.sol                                                +10       0  +100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                            -77       0  +100.00%
contracts/0.4.24/utils/UnstructuredStorageUint128.sol                     +14      +1  +92.86%
contracts/0.8.25/ValidatorExitDelayVerifier.sol                           +64       0  +100.00%
contracts/0.8.25/utils/AccessControlConfirmable.sol                        +2       0  +100.00%
contracts/0.8.25/utils/Confirmable2Addresses.sol                           +5       0  +100.00%
contracts/0.8.25/utils/Confirmations.sol                                  +37       0  +100.00%
contracts/0.8.25/utils/PausableUntilWithRoles.sol                          +3       0  +100.00%
contracts/0.8.25/vaults/LazyOracle.sol                                    +84     +67  +20.24%
contracts/0.8.25/vaults/OperatorGrid.sol                                 +149       0  +100.00%
contracts/0.8.25/vaults/PinnedBeaconProxy.sol                              +5       0  +100.00%
contracts/0.8.25/vaults/StakingVault.sol                                  +98       0  +100.00%
contracts/0.8.25/vaults/ValidatorConsolidationRequests.sol                +56      +2  +96.43%
contracts/0.8.25/vaults/VaultFactory.sol                                  +30       0  +100.00%
contracts/0.8.25/vaults/VaultHub.sol                                     +391    +168  +57.03%
contracts/0.8.25/vaults/dashboard/Dashboard.sol                          +120       0  +100.00%
contracts/0.8.25/vaults/dashboard/NodeOperatorFee.sol                     +70       0  +100.00%
contracts/0.8.25/vaults/dashboard/Permissions.sol                         +50       0  +100.00%
contracts/0.8.25/vaults/interfaces/IPredepositGuarantee.sol                 0       0  +100.00%
contracts/0.8.25/vaults/interfaces/IStakingVault.sol                        0       0  +100.00%
contracts/0.8.25/vaults/lib/PinnedBeaconUtils.sol                          +6       0  +100.00%
contracts/0.8.25/vaults/lib/RefSlotCache.sol                              +22     +17  +22.73%
contracts/0.8.25/vaults/predeposit_guarantee/CLProofVerifier.sol          +16      +1  +93.75%
contracts/0.8.25/vaults/predeposit_guarantee/MeIfNobodyElse.sol            +3       0  +100.00%
contracts/0.8.25/vaults/predeposit_guarantee/PredepositGuarantee.sol     +159       0  +100.00%
contracts/0.8.9/Accounting.sol                                            +83      +2  +97.59%
contracts/0.8.9/Burner.sol                                                +21       0  +100.00%
contracts/0.8.9/LidoLocator.sol                                            +8       0  +100.00%
contracts/0.8.9/StakingRouter.sol                                         -11       0  +100.00%
contracts/0.8.9/TriggerableWithdrawalsGateway.sol                         +54      +1  +98.15%
contracts/0.8.9/WithdrawalVault.sol                                       +11       0  +100.00%
contracts/0.8.9/WithdrawalVaultEIP7002.sol                                +21       0  +100.00%
contracts/0.8.9/lib/ExitLimitUtils.sol                                    +31       0  +100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                               -17       0  -0.11%
contracts/0.8.9/oracle/ValidatorsExitBus.sol                             +136     +10  +92.65%
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                        -38      -1  +0.31%
contracts/0.8.9/proxy/WithdrawalsManagerProxy.sol                         +60       0  +100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol               -16      +1  -0.46%
contracts/common/utils/PausableUntil.sol                                  +29       0  +100.00%
TOTAL                                                                   +1717    +281  -5.35%

Results for commit: fb4f7e5

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

TheDZhon

👀

.github/workflows/tests-integration-mainnet.yml

contracts/0.8.25/Accounting.sol

TheDZhon

👀

contracts/0.8.25/vaults/VaultHub.sol

contracts/0.8.25/utils/Versioned.sol

contracts/0.8.25/vaults/VaultBeaconChainDepositor.sol

contracts/0.8.25/vaults/VaultHub.sol

contracts/0.4.24/Lido.sol

contracts/0.8.25/Accounting.sol

contracts/0.8.25/interfaces/ILido.sol

contracts/0.8.25/vaults/VaultHub.sol

contracts/0.8.9/Burner.sol

...acts/openzeppelin/5.0.2/upgradeable/access/extensions/AccessControlEnumerableUpgradeable.sol

contracts/0.4.24/Lido.sol

TheDZhon

👀

contracts/0.8.25/vaults/VaultHub.sol

contracts/0.8.25/vaults/StakingVault.sol

contracts/0.8.25/vaults/Dashboard.sol

TheDZhon

👀 👀 👀

contracts/0.8.25/vaults/VaultHub.sol

contracts/0.8.25/vaults/StakingVault.sol

TheDZhon

🚛

contracts/0.8.25/vaults/StakingVault.sol

contracts/0.8.25/vaults/Dashboard.sol

TheDZhon

🚛 🚛 🚛

contracts/0.8.25/vaults/Delegation.sol

TheDZhon

First lap finished 👍

contracts/0.8.25/vaults/VaultFactory.sol

contracts/0.8.25/vaults/Delegation.sol

contracts/0.8.25/vaults/VaultFactory.sol

contracts/0.8.25/Accounting.sol

contracts/0.8.25/interfaces/ILido.sol

contracts/0.8.25/vaults/Dashboard.sol

contracts/0.8.25/vaults/VaultHub.sol

[VAULTS] latest minor fixes and comments

contracts/0.8.25/vaults/StakingVault.sol

contracts/0.8.25/vaults/predeposit_guarantee/CLProofVerifier.sol

contracts/common/lib/TriggerableWithdrawals.sol

contracts/0.8.25/vaults/predeposit_guarantee/PredepositGuarantee.sol

contracts/0.8.25/vaults/dashboard/NodeOperatorFee.sol

Psirex · 2025-10-16T10:42:05Z

contracts/0.8.25/vaults/dashboard/NodeOperatorFee.sol

+     * @param _expectedSettledGrowth The expected current settled growth
+     * @return bool True if correction was applied, false if awaiting confirmations
+     */
+    function correctSettledGrowth(int256 _newSettledGrowth, int256 _expectedSettledGrowth) public returns (bool) {


⚠️ This method may be difficult to use, since the trustless disburseFee() function allows anyone to modify the settledGrowth value after a new oracle report arrives. This may reduce the time window available for the node operator and vault owner to collect confirmations.

contracts/0.8.25/vaults/dashboard/NodeOperatorFee.sol

…x-no-fee

feat(Dashboard): reset settled growth on disconnect

fix(VaultHub): insufficient shortfall due to rounding

…ault-factory

feat: add vault factory chaining for upgrade

fix: fixes after the review

[VAULTS] Audit fixes 5

folkyatina changed the base branch from master to develop November 27, 2024 07:48

folkyatina changed the base branch from develop to master November 27, 2024 07:48

TheDZhon self-requested a review November 27, 2024 08:05

TheDZhon reviewed Nov 27, 2024

View reviewed changes

github-advanced-security bot found potential problems Nov 27, 2024

View reviewed changes

TheDZhon reviewed Nov 28, 2024

View reviewed changes

TheDZhon reviewed Nov 29, 2024

View reviewed changes

tamtamchik changed the base branch from master to develop November 29, 2024 11:56

folkyatina reviewed Nov 29, 2024

View reviewed changes

contracts/0.8.25/utils/Versioned.sol Outdated Show resolved Hide resolved

folkyatina reviewed Nov 29, 2024

View reviewed changes

contracts/0.8.25/vaults/VaultBeaconChainDepositor.sol Outdated Show resolved Hide resolved

folkyatina reviewed Nov 29, 2024

View reviewed changes

contracts/0.8.25/vaults/VaultHub.sol Outdated Show resolved Hide resolved

folkyatina reviewed Nov 29, 2024

View reviewed changes

contracts/0.8.25/vaults/VaultHub.sol Outdated Show resolved Hide resolved

folkyatina reviewed Nov 29, 2024

View reviewed changes

contracts/0.8.25/vaults/VaultHub.sol Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Dec 2, 2024

View reviewed changes

folkyatina reviewed Dec 3, 2024

View reviewed changes

contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved

folkyatina reviewed Dec 3, 2024

View reviewed changes

contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved

folkyatina reviewed Dec 3, 2024

View reviewed changes

contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved

TheDZhon reviewed Dec 4, 2024

View reviewed changes

Jeday reviewed Dec 5, 2024

View reviewed changes

contracts/0.8.25/vaults/StakingVault.sol Outdated Show resolved Hide resolved

contracts/0.8.25/vaults/Dashboard.sol Outdated Show resolved Hide resolved

Jeday reviewed Dec 5, 2024

View reviewed changes

contracts/0.8.25/vaults/Dashboard.sol Outdated Show resolved Hide resolved

Jeday reviewed Dec 5, 2024

View reviewed changes

contracts/0.8.25/vaults/Dashboard.sol Outdated Show resolved Hide resolved

contracts/0.8.25/vaults/Dashboard.sol Outdated Show resolved Hide resolved

TheDZhon reviewed Dec 5, 2024

View reviewed changes

TheDZhon reviewed Dec 11, 2024

View reviewed changes

TheDZhon reviewed Dec 12, 2024

View reviewed changes

tamtamchik added solidity Smart contract code changes next upgrade Things to pickup for the next protocol upgrade vaults Lido stVaults related changes labels Dec 12, 2024

TheDZhon reviewed Dec 13, 2024

View reviewed changes

github-advanced-security bot found potential problems Dec 18, 2024

View reviewed changes

contracts/0.8.25/Accounting.sol Fixed Show fixed Hide fixed

contracts/0.8.25/interfaces/ILido.sol Fixed Show fixed Hide fixed

contracts/0.8.25/vaults/Dashboard.sol Fixed Show fixed Hide fixed

contracts/0.8.25/vaults/VaultHub.sol Fixed Show fixed Hide fixed

folkyatina added 13 commits October 15, 2025 20:40

test: fix pdg integration test for hoodi

d636abf

chore: fix params filename

55b71dd

chore: fix path to upgrade params

a56d4be

test: fix upgrade template test flow

132de30

chore: fix warnings

6b758ed

test: fix upgrade template testing

a2103d5

docs: better natspec for Dashboard

b9d66cb

chore: fix a warning

ca97347

chore: fix some comments

4204ee6

fix(Dashboard): add return bool for transferVaultOwnership

ffee488

chore: more natspec improvements

acba5fe

fix(OperatorGrid): add confirm expiry setter

9e795b0

Merge pull request #1511 from lidofinance/fix/pdg-small-fixes

90b43f0

[VAULTS] latest minor fixes and comments

Psirex reviewed Oct 16, 2025

View reviewed changes

failingtwice and others added 10 commits October 16, 2025 22:29

Merge branch 'audit-6' of https://github.com/lidofinance/core into fi…

f643fe8

…x-no-fee

test: fix hardcoded values

96fb51a

Merge pull request #1506 from lidofinance/fix-no-fee

7521df1

feat(Dashboard): reset settled growth on disconnect

Merge pull request #1497 from lidofinance/shortfall-rounding-fix

1f44239

fix(VaultHub): insufficient shortfall due to rounding

feat: add vault factory chaining for upgrade

4b2ca37

fix: fix upgrade deploy for the new factory

f6a4d14

test: fix a flaky test

ad8e59d

Merge remote-tracking branch 'origin/audit-6' into feat/upgreadable-v…

1afcebc

…ault-factory

test: add some tests for the factory

0436884

fix: fixes after the review

5e71d92

folkyatina mentioned this pull request Oct 19, 2025

fix: fixes after the review #1515

Merged

folkyatina added 5 commits October 19, 2025 13:34

chore(LazyOracle): add natspec and rearrange methods a bit

4c9ce94

Merge pull request #1513 from lidofinance/feat/upgreadable-vault-factory

176d889

feat: add vault factory chaining for upgrade

fix(TW): hardened assembly

8f9cc04

Merge pull request #1515 from lidofinance/fix/prosecco-review-comments

25c2be3

fix: fixes after the review

Merge pull request #1512 from lidofinance/audit-6

7cae7a1

[VAULTS] Audit fixes 5

[EPIC] stVaults #874

Are you sure you want to change the base?

[EPIC] stVaults #874

Uh oh!

Conversation

tamtamchik commented Nov 17, 2024 • edited by folkyatina Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❗ 🚧 Under construction 🚧 ❗

Staking Vaults

Uh oh!

TheDZhon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-advanced-security bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Hardhat Unit Tests Coverage Summary

Diff against master

Uh oh!

TheDZhon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheDZhon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheDZhon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tamtamchik commented Nov 17, 2024 •

edited by folkyatina

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading