Feat: revoke possibility to revoke funds from NOR contract #1510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close
transferToVault
function with a revert to properly address the security issue.Context
Anyone could transfer funds to the trusted wallet from the NOR contract before rewards were distributed to NOs.
Returning those funds to the NOs required additional operational work.
Problem
This change closes a previously mitigated security issue:
https://research.lido.fi/t/post-mortem-nor-curated-module-sdvt-recovery-lever-weakness/10282