Fix vault freshness check and repeating reports #1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkyatina
added
solidity
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: b284ef8 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
folkyatina
added a commit
that referenced
this pull request
Jul 4, 2025
folkyatina
force-pushed
the
fix/report-freshness
branch
from
9627031 to
9e5226d
Compare
TheDZhon
approved these changes
Jul 17, 2025
Comment on lines
+1194
to
+1198
| // happy path. vault's report ts is the same as the latest AO report ts | ||
| if (latestReportTimestamp32 == vaultReportTimestamp) { | ||
| // check if AO has not stopped bringing the report | ||
| return block.timestamp - latestReportTimestamp < REPORT_FRESHNESS_DELTA; | ||
| } |
There was a problem hiding this comment.
Suggested change
| // happy path. vault's report ts is the same as the latest AO report ts | |
| if (latestReportTimestamp32 == vaultReportTimestamp) { | |
| // check if AO has not stopped bringing the report | |
| return block.timestamp - latestReportTimestamp < REPORT_FRESHNESS_DELTA; | |
| } |
🔪
| /// @dev Returns the distance between two 32-bit numbers in counterclockwise direction | ||
| /// @param a the first number that's suppose to be larger than b | ||
| /// @param b the second number that's suppose to be smaller than a | ||
| /// @return the distance between a and b in counterclockwise direction modulo 2**32 + 1 |
There was a problem hiding this comment.
Suggested change
| /// @return the distance between a and b in counterclockwise direction modulo 2**32 + 1 | |
| /// @return the distance between a and b in counterclockwise direction modulo 2**32 |
| /// @return the distance between a and b in counterclockwise direction modulo 2**32 + 1 | ||
| /// @dev this function is used to check if a is larger than b taking into account the overflow of uint32 | ||
| function ccwDistance32(uint32 a, uint32 b) internal pure returns (uint256) { | ||
| uint256 modulo = uint256(~uint32(0)) + 1; |
There was a problem hiding this comment.
Suggested change
| uint256 modulo = uint256(~uint32(0)) + 1; | |
| uint256 modulo = 1 << 32; |
folkyatina
changed the title
This was
linked to
issues
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1190
Fix #1200