-
Notifications
You must be signed in to change notification settings - Fork 29
fix(slack): preserve active prefetch claims under cap #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b5b34bf
fix(slack): preserve active prefetch claims under cap
parkjs101 7400e95
Merge remote-tracking branch 'origin/dev' into codex/issue-317-slack-…
parkjs101 4afc972
Merge remote-tracking branch 'origin/dev' into codex/issue-317-slack-…
parkjs101 ae7f055
fix(slack): release prefetch claims before handoff
parkjs101 9f5c346
Merge remote-tracking branch 'origin/dev' into codex/issue-317-slack-…
parkjs101 4cf9868
test(install): scope native Windows README guard
parkjs101 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Release claims on every pre-enqueue exit.
processSlackMessageEventreleases only claims that reach itsfinally.handleSlackEnvelopeacquiresprefetchTokenbefore attachment recovery, then can return at Line 500 or Lines 503-511 without passing the claim to this function. An attachment-recovery exception has the same result.These paths leave an uncommitted claim active. The new capacity logic cannot evict active claims. After 500 such threaded events, all later prefetch claims are declined until reset.
Wrap post-claim work in a
try/finally. Release the token unlessenqueueSlackIngressaccepts ownership.Proposed lifecycle guard
const prefetchToken = event.thread_ts ? claimThreadPrefetch(event.channel || '', event.thread_ts) : 0; +let prefetchHandedOff = false; -const target = buildSlackTarget(event); +try { +const target = buildSlackTarget(event); // ... attachment recovery and early-return paths ... enqueueSlackIngress(slackIngressLaneKey(target), signal => processSlackMessageEvent(event, target, text, signal, { prefetchToken, // ... })); +prefetchHandedOff = true; +} finally { + if (prefetchToken && !prefetchHandedOff) { + releaseThreadPrefetch(event.channel || '', event.thread_ts || '', prefetchToken); + } +}🤖 Prompt for AI Agents