Skip to content

chore: update skills_ref for safe OfficeCLI writes - #304

Merged
parkjs101 merged 1 commit into
lidge-jun:devfrom
parkjs101:codex/p1-officecli-wiki-closeout
Aug 12, 2026
Merged

chore: update skills_ref for safe OfficeCLI writes#304
parkjs101 merged 1 commit into
lidge-jun:devfrom
parkjs101:codex/p1-officecli-wiki-closeout

Conversation

@parkjs101

Copy link
Copy Markdown
Collaborator

What changed

Advances the skills_ref submodule from 2b14081c to merged commit 8f8e393c (cli-jaw-skills PR #1).

The merged skills change:

  • routes Windows DataFrame bulk writes through explicit-cell officecli batch --input
  • preserves CJK, embedded newlines, and numeric types
  • requires officecli close plus exact persisted-cell read-back
  • keeps officecli import only as a verified non-Windows legacy path

This closes the cli-jaw-owned routing gap reported in #279 and #295.

Root cause

On Windows, released OfficeCLI builds can report a successful CSV import and pass validate while persisting empty cells. The skill previously recommended that silent-loss path as its default.

Verification

  • rebased on current origin/dev (c6b3e0a5)
  • OFFICECLI_BIN=C:\Users\user\AppData\Local\OfficeCli\officecli.exe uv run --no-project --with pytest pytest skills_ref/tests/test_officecli_data_pipeline.py -q7 passed
  • real OfficeCLI 1.0.45 round-trip verifies Korean text, an embedded newline, and numeric data after close
  • git diff --check origin/dev...HEAD passed

Closes #279
Closes #295

@parkjs101
parkjs101 marked this pull request as ready for review August 12, 2026 06:16
@parkjs101
parkjs101 merged commit a5faabe into lidge-jun:dev Aug 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant