Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scp, ftps, ftpes, irc, ircs schemes #16

Merged
merged 9 commits into from
Oct 8, 2024

Conversation

SineSwiper
Copy link
Contributor

Added several schemes that were simple to implement, as they were aliases or mostly aliases to existing types. I also added the irc scheme, based on existing IRC URI drafts, and its secure cousin, ircs.

URI::sftp is already out there in the wild, but it would be nice to bring this thing into the core URI distro.

@karenetheridge
Copy link
Member

Since this duplicates modules already on the cpan, appropriate permissions would need to be granted by those that currently hold them.

@SineSwiper
Copy link
Contributor Author

Perhaps that can be split off into a separate issue. I can adjust the branch and create another PR.

@SineSwiper SineSwiper changed the title Add scp, sftp, ftps, irc, ircs schemes Add scp, ftps, irc, ircs schemes Apr 18, 2014
@SineSwiper
Copy link
Contributor Author

Ping!

@SineSwiper SineSwiper changed the title Add scp, ftps, irc, ircs schemes Add scp, ftps, ftpes, irc, ircs schemes Feb 9, 2015
@karenetheridge karenetheridge self-assigned this Jul 7, 2015
@oalders
Copy link
Member

oalders commented Aug 21, 2023

It looks like we're now shipping URI::sftp with URI. @SineSwiper do you still have interest in getting some of this merged? I have no idea why it got stalled.

@SineSwiper SineSwiper force-pushed the topic/more_schemes branch 2 times, most recently from 577e546 to 0f0681d Compare August 23, 2024 20:02
@SineSwiper
Copy link
Contributor Author

@oalders, @karenetheridge Apologies for the (very late) delay, but I noticed there was still an interest in getting this merged. So, I rebased it and cleaned it up to match the newer URI fixes (Test::More, DZIL, etc.).

@karenetheridge karenetheridge removed their assignment Aug 23, 2024
@oalders oalders self-assigned this Aug 24, 2024
@oalders
Copy link
Member

oalders commented Sep 29, 2024

@SineSwiper sorry for the delay in review. What do you think about adding some basic tests for the new modules which don't yet have coverage?

@SineSwiper
Copy link
Contributor Author

@oalders, there should be some unit tests for the new modules in the commits. Did you find any modules missing tests?

@oalders
Copy link
Member

oalders commented Oct 1, 2024

@SineSwiper I see what you mean now. At first glance I saw new modules, but I didn't see corresponding test files for each.

If it's not too much trouble, could we put the ircs and ftpes tests into their own .t files? I think that makes it easier to get a quick overview of things.

Maybe if we added a compile test or something basic for scp as well? I don't see anything for that.

@SineSwiper
Copy link
Contributor Author

Okay, I split up the tests, added some new ones, and rebased to fix the $VERSION mismatches.

@oalders
Copy link
Member

oalders commented Oct 8, 2024

It took an entire decade, but we got there. 😅 Sorry for the delay @SineSwiper (I think this predates me?) and thank you for your patience.

@oalders oalders merged commit 225f518 into libwww-perl:master Oct 8, 2024
42 checks passed
@oalders
Copy link
Member

oalders commented Oct 9, 2024

Oof. I should have checked first:

Status: Permission missing

 module : URI::ftpes
 version: 5.30
 in file: lib/URI/ftpes.pm
 status : Not indexed because permission missing. Current registered
          primary maintainer is STEFANOS. Hint: you can always find
          the legitimate maintainer(s) on PAUSE under "View
          Permissions".

 module : URI::ftps
 version: 5.30
 in file: lib/URI/ftps.pm
 status : Not indexed because permission missing. Current registered
          primary maintainer is STEFANOS. Hint: you can always find
          the legitimate maintainer(s) on PAUSE under "View
          Permissions".

 module : URI::scp
 version: 5.30
 in file: lib/URI/scp.pm
 status : Not indexed because permission missing. Current registered
          primary maintainer is STEFANOS. Hint: you can always find
          the legitimate maintainer(s) on PAUSE under "View
          Permissions".

@oalders
Copy link
Member

oalders commented Oct 9, 2024

It looks like those are actually just on BackPAN. I'll contact a PAUSE admin about transferring perms.

@SineSwiper SineSwiper deleted the topic/more_schemes branch October 9, 2024 19:40
@SineSwiper
Copy link
Contributor Author

No worries! Thanks for getting it merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants