-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scp, ftps, ftpes, irc, ircs schemes #16
Conversation
Since this duplicates modules already on the cpan, appropriate permissions would need to be granted by those that currently hold them. |
Perhaps that can be split off into a separate issue. I can adjust the branch and create another PR. |
Ping! |
275946a
to
041f018
Compare
5dcfddf
to
3a2965a
Compare
It looks like we're now shipping |
577e546
to
0f0681d
Compare
@oalders, @karenetheridge Apologies for the (very late) delay, but I noticed there was still an interest in getting this merged. So, I rebased it and cleaned it up to match the newer URI fixes (Test::More, DZIL, etc.). |
@SineSwiper sorry for the delay in review. What do you think about adding some basic tests for the new modules which don't yet have coverage? |
@oalders, there should be some unit tests for the new modules in the commits. Did you find any modules missing tests? |
@SineSwiper I see what you mean now. At first glance I saw new modules, but I didn't see corresponding test files for each. If it's not too much trouble, could we put the Maybe if we added a compile test or something basic for |
9bffbe1
to
23fc023
Compare
Okay, I split up the tests, added some new ones, and rebased to fix the |
It took an entire decade, but we got there. 😅 Sorry for the delay @SineSwiper (I think this predates me?) and thank you for your patience. |
Oof. I should have checked first:
|
It looks like those are actually just on BackPAN. I'll contact a PAUSE admin about transferring perms. |
No worries! Thanks for getting it merged! |
Added several schemes that were simple to implement, as they were aliases or mostly aliases to existing types. I also added the irc scheme, based on existing IRC URI drafts, and its secure cousin, ircs.
URI::sftp is already out there in the wild, but it would be nice to bring this thing into the core URI distro.