Add support for Item subclasses. #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. Item can have category marc:hold but the subclass SingleItem can have category marc:none.
olovy
requested review from
jannistsiroyannis,
kwahlin,
lrosenstrom and
niklasl
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to have linked
SingleItem(sv: "Exemplar") insideItemhasComponent.SingleItemis in collectionnoneinstead ofholdso that we don't get any of the special handling for holdingsSingleItemrecords per libraryhasComponentof a regular holding recordIteminstead of just collectionholdSingleItemSee also
libris/definitions#494
Later on
Itemmight be replaced byItemHoldingfor the holding, withSingleItemandSomeItemfor 1 vs many items.See libris/definitions#483