Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors #121

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

Refactors #121

wants to merge 48 commits into from

Conversation

LibretroAdmin
Copy link
Contributor

No description provided.

@LibretroAdmin
(snd_dma.c) Remove unnecessary console commands
5f05ce9
@LibretroAdmin
* Get rid of various console commands that will never be used for the…
8685a8d 
… libretro port:

- cl_shownet
- developer
- entities
- mcache
- host_framerate
- host_speeds
- maplist
- d_subdiv16
- hunk
* Get rid of PARANOID ifdefs - never used and speed-sapping according to own internal
comments
* Keys - get rid of console autocompletion - will never be used
* Get rid of useless window_visible - libretro port doesn't need to have a concept of this
* Get rid of useless onscreen logging functionality like R_TimeRefresh, R_TimeGraph, R_ZGraph, etc.
* Get rid of Con_DPrintf - only ever used when developer switch is set, which will never
be the case for the libretro port
* Get rid of debuglog
@LibretroAdmin
r_pixbytes is always going to be 1 for the libretro core, get rid
c1fbd4c 
of alternate r_pixbytes codepaths - less conditionals, less code
@LibretroAdmin
Get rid of unused msg_suppress_
e0cc02b
@LibretroAdmin
Get rid of some unused variables as a result of earlier code refactors
fe821a7
@LibretroAdmin
Get rid of unused frontend VID_ functions in libretro.c
4f468cc
@LibretroAdmin
(Sound) Optimize around 16bit stereo sound, libretro port will
94bf7b8 
never change from this, remove all alternate code paths
@LibretroAdmin
* Remove unused IN_Commands
c1636b1 
* Remove some unused variables/command variables
* Simplify audio code - shm->samples will always be constant, so use
a constant define. Plan to eventually get rid of shm struct/pointer
(see comment in snd_dma/snd_mix.c code that this should be removed eventually)
@LibretroAdmin
* Remove unneeded debug code (including member variable height of sur…
7b8ec43 
…fcache_s)

* Remove unneeded low floating point/high floating point mode setting (this was
only ever relevant on old 486/Pentium era CPUs)
* Get rid of more useless debug functions
* Direct initialization of local variables where possible
@LibretroAdmin
Remove if 0 codeblocks
431694a
@LibretroAdmin
No need for if 1 statements
d4f4167
@LibretroAdmin
Remove demo recording
e6023ef
@LibretroAdmin
Remove unused variables that got incremented every frame
6e408de
@LibretroAdmin
Remove scr_ram/scr_net and DrawNet
f62cf64
@LibretroAdmin
r_recursiveaffinetriangles is always enabled
bbc5d8e
@LibretroAdmin
Get rid of r_drawentities - remove more unused functions
3fc527c
@LibretroAdmin
Don't write keybinds to config.cfg
2d3450a
@LibretroAdmin
Remove unused function call declarations for rfprintf
67bb497
@LibretroAdmin
Cleanups
7fb147f
@LibretroAdmin
Miscellanous cleanups - turn functions static if we can
edc4517
@LibretroAdmin
Get rid of unnecessary console commands viewframe, viewmodel, viewmod…
63d299a 
…el_prev,

viewmodel_next, version
@LibretroAdmin
* COM_LoadPakFile - CRC checking on PAK file is unnecessary
a30501b 
* draworder always 0, remove conditional
* Random miscellaneous cleanups, make functions static if we can
@LibretroAdmin
Get rid of unused variables r_fullbright, r_ambient, r_pointfile
85b6e57
@LibretroAdmin
Get rid of unused snd_noextraupdate
4914587
@LibretroAdmin
Remove unused cl_warncmd
6ed9256
@LibretroAdmin
Remove unused extern
7750e1c
@LibretroAdmin
Cleanups
ededcc5
@LibretroAdmin
Cleanups in pr_exec.c
3ce2b42
@LibretroAdmin
Simplify code - get rid of unused net_win files
e98949c
@LibretroAdmin
Doesn't read or write to config.cfg anymore - options will be added
fb10716 
from now on to core options
@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2022

This pull request fixes 42 alerts when merging 67bd259 into c2b8ea0 - view on LGTM.com

fixed alerts:

  • 23 for FIXME comment
  • 17 for Local variable hides global variable
  • 1 for Wrong type of arguments to formatting function
  • 1 for Too few arguments to formatting function

@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2022

This pull request fixes 42 alerts when merging c7d6d6d into c2b8ea0 - view on LGTM.com

fixed alerts:

  • 23 for FIXME comment
  • 17 for Local variable hides global variable
  • 1 for Wrong type of arguments to formatting function
  • 1 for Too few arguments to formatting function

@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2022

This pull request fixes 42 alerts when merging 8a3b554 into c2b8ea0 - view on LGTM.com

fixed alerts:

  • 23 for FIXME comment
  • 17 for Local variable hides global variable
  • 1 for Wrong type of arguments to formatting function
  • 1 for Too few arguments to formatting function

@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2022

This pull request fixes 42 alerts when merging 8d94cd3 into c2b8ea0 - view on LGTM.com

fixed alerts:

  • 23 for FIXME comment
  • 17 for Local variable hides global variable
  • 1 for Wrong type of arguments to formatting function
  • 1 for Too few arguments to formatting function

@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2022

This pull request fixes 42 alerts when merging cfe5014 into c2b8ea0 - view on LGTM.com

fixed alerts:

  • 23 for FIXME comment
  • 17 for Local variable hides global variable
  • 1 for Wrong type of arguments to formatting function
  • 1 for Too few arguments to formatting function

@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2022

This pull request fixes 42 alerts when merging a8ea1e1 into c2b8ea0 - view on LGTM.com

fixed alerts:

  • 23 for FIXME comment
  • 17 for Local variable hides global variable
  • 1 for Wrong type of arguments to formatting function
  • 1 for Too few arguments to formatting function

@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2022

This pull request fixes 43 alerts when merging a273599 into c2b8ea0 - view on LGTM.com

fixed alerts:

  • 24 for FIXME comment
  • 17 for Local variable hides global variable
  • 1 for Wrong type of arguments to formatting function
  • 1 for Too few arguments to formatting function

@LibretroAdmin
* Use fill_pathname_join where possible instead of snprintf
e04da40 
* Use strlcpy where possible instead of snprintf
* Get rid of 'bad CDRIP'warning whenever an audio track cannot be found
@lgtm-com
Copy link

lgtm-com bot commented Jun 12, 2022

This pull request fixes 43 alerts when merging e04da40 into c2b8ea0 - view on LGTM.com

fixed alerts:

  • 24 for FIXME comment
  • 17 for Local variable hides global variable
  • 1 for Wrong type of arguments to formatting function
  • 1 for Too few arguments to formatting function

@lgtm-com
Copy link

lgtm-com bot commented Jun 12, 2022

This pull request fixes 43 alerts when merging 9911d91 into c2b8ea0 - view on LGTM.com

fixed alerts:

  • 24 for FIXME comment
  • 17 for Local variable hides global variable
  • 1 for Wrong type of arguments to formatting function
  • 1 for Too few arguments to formatting function

@lgtm-com
Copy link

lgtm-com bot commented Jun 13, 2022

This pull request introduces 1 alert and fixes 44 when merging 2169d02 into c2b8ea0 - view on LGTM.com

new alerts:

  • 1 for FIXME comment

fixed alerts:

  • 25 for FIXME comment
  • 17 for Local variable hides global variable
  • 1 for Wrong type of arguments to formatting function
  • 1 for Too few arguments to formatting function

@lgtm-com
Copy link

lgtm-com bot commented Jun 13, 2022

This pull request introduces 1 alert and fixes 45 when merging 1947981 into c2b8ea0 - view on LGTM.com

new alerts:

  • 1 for FIXME comment

fixed alerts:

  • 26 for FIXME comment
  • 17 for Local variable hides global variable
  • 1 for Wrong type of arguments to formatting function
  • 1 for Too few arguments to formatting function

@lgtm-com
Copy link

lgtm-com bot commented Jul 22, 2022

This pull request introduces 1 alert and fixes 45 when merging 1e2464b into e84d6c1 - view on LGTM.com

new alerts:

  • 1 for FIXME comment

fixed alerts:

  • 26 for FIXME comment
  • 17 for Local variable hides global variable
  • 1 for Wrong type of arguments to formatting function
  • 1 for Too few arguments to formatting function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LibretroAdmin