Skip to content

Commit

Permalink
Backport PR SourMesen#879
Browse files Browse the repository at this point in the history
  • Loading branch information
@inactive123
inactive123 committed Oct 6, 2020
1 parent 86326e8 commit 1294e2d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Libretro/libretro.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ extern "C" {
_console->GetSettings()->SetSampleRate(_audioSampleRate);
_console->GetSettings()->SetAutoSaveOptions(0, false);
_console->GetSettings()->SetRewindBufferSize(0);
_console->GetSettings()->SetFlags(EmulationFlags::AllowMismatchingSaveState);
}

RETRO_API void retro_deinit()
Expand Down

4 comments on commit 1294e2d

@negativeExponent
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've wonder what this is suppose to do. isn't it that the more deterministic the states are for libretro the better? for runahead and probably netplay.

@SimpleTease
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mesen normally blocks loadstate if rom hash doesn't match. For gamers that experiment with lots of different hacks, it's a real pain. 🤣

@keithbowes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any intention of merging in the other PRs (especially SourMesen#868; the others seem to only affect standalone Mesen)? Also, has this fork become the officially sanctioned successor of the discontinued original, like was done with Nestopia?

@SimpleTease: That's interesting. I assumed it had to do with the ability to use savestates from older Mesen versions.

@inactive123
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In hindsight I kinda agree with @negativeExponent, this will hurt netplay since determinism is very important there. For that reason I will err on the side of caution and revert this.

Please sign in to comment.