Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests for macos-14 on arm64 #1027

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Mar 21, 2024

macos-12 and macos-13 fails make test on arm64 but macos-14 can pass.
Hence this patch enables it on github action.

macos-12 and macos-13 fails `make test` on arm64 but macos-14 does not.
Hence this patch enables it on github action.
@botovq
Copy link
Contributor

botovq commented Mar 21, 2024 via email

@nak3
Copy link
Contributor Author

nak3 commented Mar 22, 2024

What fails on macos-12 and macos-13?

The error produces [Unknown system error -86]. Unfortunately macOS does not provide much the hint.

log - https://github.com/nak3/portable/actions/runs/8373109169/job/22925506730

2024-03-21T10:11:30.9340490Z + make test
2024-03-21T10:11:30.9584630Z Running tests...
2024-03-21T10:11:31.0164090Z Test project /Users/runner/work/portable/portable/libressl-3.9.0/build-static
2024-03-21T10:11:31.0217920Z         Start   1: aeadtest
2024-03-21T10:11:31.0269460Z   1/125 Test   #1: aeadtest .........................***Failed    0.00 sec
2024-03-21T10:11:31.0272950Z         Start   2: aes_test
2024-03-21T10:11:31.0276700Z Process not started
2024-03-21T10:11:31.0277940Z  /Users/runner/work/portable/portable/libressl-3.9.0/build-static/tests/aes_test
2024-03-21T10:11:31.0278880Z [Unknown system error -86]
2024-03-21T10:11:31.0279490Z   2/125 Test   #2: aes_test .........................***Not Run   0.00 sec
2024-03-21T10:11:31.0280740Z         Start   3: aes_wrap
2024-03-21T10:11:31.0284970Z Process not started
2024-03-21T10:11:31.0286040Z  /Users/runner/work/portable/portable/libressl-3.9.0/build-static/tests/aes_wrap
2024-03-21T10:11:31.0286960Z [Unknown system error -86]
...

I'd like to repeat my concern: macos is by far the slowest of the CI.
It's annoying to wait for it. Can it reasonably be split? Perhaps if 12
and 13 aren't fixable on the M1, we could have a legacy macos CI and a
macos 14 CI?

Sure, I split the job into two files.

@botovq botovq requested a review from joshuasing March 22, 2024 04:24
@nak3
Copy link
Contributor Author

nak3 commented Mar 25, 2024

@joshuasing Could you please take a look? (I found that you were requested for the review.)

Copy link
Member

@joshuasing joshuasing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind undoing moving macos-13 and macos-12 to a separate workflow?
I don't believe this change will make much of a difference in terms of run time.

@nak3
Copy link
Contributor Author

nak3 commented Mar 25, 2024

Alright, updated. Thanks.

@botovq botovq merged commit 577970a into libressl:master Mar 25, 2024
41 checks passed
@nak3 nak3 deleted the add-macos-non-x86 branch March 25, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants