-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests for macos-14 on arm64 #1027
Conversation
macos-12 and macos-13 fails `make test` on arm64 but macos-14 does not. Hence this patch enables it on github action.
Thanks. What fails on macos-12 and macos-13?
I'd like to repeat my concern: macos is by far the slowest of the CI.
It's annoying to wait for it. Can it reasonably be split? Perhaps if 12
and 13 aren't fixable on the M1, we could have a legacy macos CI and a
macos 14 CI?
|
The error produces log - https://github.com/nak3/portable/actions/runs/8373109169/job/22925506730
Sure, I split the job into two files. |
@joshuasing Could you please take a look? (I found that you were requested for the review.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind undoing moving macos-13 and macos-12 to a separate workflow?
I don't believe this change will make much of a difference in terms of run time.
This reverts commit 51e6f0e.
Alright, updated. Thanks. |
macos-12 and macos-13 fails
make test
on arm64 but macos-14 can pass.Hence this patch enables it on github action.