Fix 'play' command requiring 'offset' field #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
photovoltex
requested changes
Dec 14, 2024
connect/src/model.rs
Outdated
| warn!("SkipTo didn't provided any point to skip to, falling back to index 0"); | ||
| 0 | ||
| })) | ||
| impl From<Option<SkipTo>> for PlayingTrack { |
There was a problem hiding this comment.
Can you instead of adjusting the From, derive Default for SkipTo and unwrap_or_default? Pretty much so that we don't have to touch the From at all^^
There was a problem hiding this comment.
Thanks, that's nicer.
There was a problem hiding this comment.
Yeah, you can easily run into deep indentation issues with rust. There are ways around it, but usually they are not the obvious one. Anyhow thanks for the adjustment^^
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1417.