Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/dependencies #1416

Merged
merged 8 commits into from
Dec 14, 2024
Merged

Conversation

yubiuser
Copy link
Contributor

@yubiuser yubiuser commented Dec 14, 2024

Updates

librespot
/workspaces/librespot/Cargo.toml
dependency  current  upgrade
sysinfo     0.31.4   0.33.0
thiserror   1.0.69   2.0.7

librespot-audio
/workspaces/librespot/audio/Cargo.toml
dependency  current  upgrade
thiserror   1.0.69   2.0.7

librespot-core
/workspaces/librespot/core/Cargo.toml
dependency  current  upgrade
governor    0.6.3    0.8.0
quick-xml   0.36.2   0.37.1
sysinfo     0.31.4   0.33.0
thiserror   1.0.69   2.0.7

librespot-oauth
/workspaces/librespot/oauth/Cargo.toml
dependency  current  upgrade
thiserror   1.0.69   2.0.7

librespot-connect
/workspaces/librespot/connect/Cargo.toml
dependency  current  upgrade
thiserror   1.0.69   2.0.7

librespot-playback
/workspaces/librespot/playback/Cargo.toml
dependency  current  upgrade
rodio       0.19.0   0.20.1
thiserror   1.0.69   2.0.7
zerocopy    0.7.35   0.8.13

librespot-metadata
/workspaces/librespot/metadata/Cargo.toml
dependency  current  upgrade
thiserror   1.0.69   2.0.7

librespot-discovery
/workspaces/librespot/discovery/Cargo.toml
dependency  current  upgrade
thiserror   1.0.69   2.0.7

@yubiuser
Copy link
Contributor Author

I did not update jack and zbus as both require MSRV 1.80.0

@yubiuser yubiuser force-pushed the update/dependencies branch from 9baf49b to dd1cd36 Compare December 14, 2024 20:27
@yubiuser yubiuser marked this pull request as ready for review December 14, 2024 20:51
@roderickvd
Copy link
Member

👌

@@ -390,7 +390,7 @@ impl Session {
}

pub fn set_session_id(&self, session_id: String) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you additionally change the type to &str and check where the method is used and remove possible clones?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang, missed that comment just as I merged. Please submit as an additional PR - sorry and thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah was a bit to slow there^^;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roderickvd roderickvd merged commit 2a6d754 into librespot-org:dev Dec 14, 2024
13 checks passed
@yubiuser yubiuser deleted the update/dependencies branch December 14, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants