ruby 3.2.6, bundler 2.6.2, add checksums to lockfile, ci simplification #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiegz
changed the title
tiegz
force-pushed
the
tz/add-checksums-to-lockfile
branch
2 times, most recently
from
df479cf to
ef3fcce
Compare
|
In favor but circle seems unhappy? |
|
@katzj yeah, I was struggling with Circle on this 😭 Might pick it up again later today to retry |
tiegz
force-pushed
the
tz/add-checksums-to-lockfile
branch
from
f08aa6e to
d1e4cd2
Compare
tiegz
force-pushed
the
tz/add-checksums-to-lockfile
branch
6 times, most recently
from
63aed2f to
6664fa4
Compare
tiegz
force-pushed
the
tz/add-checksums-to-lockfile
branch
from
837bee3 to
530bd11
Compare
tiegz
commented
Jan 4, 2025
|
|
||
| executors: | ||
| # TODO: we don't need ES/PG/Redis for "lint" job, so we could create another | ||
| # stripped-down executor if we want? | ||
| libraries: | ||
| working_directory: ~/libraries | ||
| docker: | ||
| - image: ruby:3.2.5-slim-bullseye | ||
| - image: cimg/ruby:3.2-node |
There was a problem hiding this comment.
I think we just needed the custom debian packages below for node, so this switches to the node image
| command: | | ||
| gem -v | ||
| bundle -v | ||
| bundle config path vendor/bundle |
There was a problem hiding this comment.
this is already set by ruby/install-deps
tiegz
changed the title
havocp
approved these changes
Jan 4, 2025
tiegz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checksums announcement: https://bundler.io/blog/2024/12/19/bundler-v2-6.html
the checksums were added manually to Gemfile.lock via
bundle lock --add-checksumsUpdate bundler to 2.6.1+ locally
bundle update --bundler