Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pubsub browser peer discovery #133

Merged
merged 13 commits into from
May 7, 2024
Merged

feat: add pubsub browser peer discovery #133

merged 13 commits into from
May 7, 2024

Conversation

2color
Copy link
Collaborator

@2color 2color commented Apr 30, 2024 •
edited
Loading

Goal

Use a dedicated pubsub topic for browsers to discovery each other. The Go peer subscribes to the topic only to serve as a message relay (it does not act on the messages)

Notes

  • In some situations, browsers will initiate a connection to each other at the same time resulting in a duplicate connection to the same peer:
    Screenshot 2024-05-06 at 2 57 39 pm

Open questions

  • (solved) How to ensure that js peers use the direct webrtc connections.
    • We filter the connections we discover and only try dialing webrtc multiaddrs.

Notes

If this works it would solve #95

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universal-connectivity ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 10:22am

@2color 2color marked this pull request as ready for review May 6, 2024 12:54
@2color 2color requested a review from a team as a code owner May 6, 2024 12:54
@2color 2color requested a review from a team May 6, 2024 12:54
@2color 2color requested review from maschad and achingbrain May 6, 2024 13:00
maschad
maschad approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2color 2color merged commit bcce1fb into main May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2color @maschad