fix(autonat): close dial-back connections to prevent memory leak#6528
Open
imabdulbasit wants to merge 1 commit into
Open
fix(autonat): close dial-back connections to prevent memory leak#6528imabdulbasit wants to merge 1 commit into
imabdulbasit wants to merge 1 commit into
Conversation
imabdulbasit
force-pushed
the
fix/autonat-close-probe-connection
branch
from
July 17, 2026 16:11
18e6d56 to
31bc937
Compare
imabdulbasit
force-pushed
the
fix/autonat-close-probe-connection
branch
from
July 17, 2026 16:21
31bc937 to
500c5a4
Compare
imabdulbasit
marked this pull request as ready for review
July 17, 2026 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The AutoNAT server (v1 and v2) dials clients back on a newly allocated port to probe reachability but never closes the resulting connection: the result is delivered over the client's original connection, while other behaviours keep the dial-back connection alive indefinitely. On QUIC each such connection pins a dedicated
quinn::Endpoint(its own UDP socket plus several MiB of buffers), so a probe-serving node leaks memory slowly but without bound. This PR closes the dial-back connection once the probe completesAI Assistance Disclosure
Tools used (required — write
noneif no AI was used): Claude CodeAttestation (required):
Notes & open questions
Change checklist