feat: broadcasting idontwant for published messages
#5773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
dismissed
jxs’s stale review
Approvals have been dismissed because the PR was updated after the send-it label was applied.
jxs
approved these changes
Jan 4, 2025
jxs
pushed a commit
to jxs/rust-libp2p
that referenced
this pull request
Jan 6, 2025
This PR introduces an optimisation to preemptively broadcast `IDONTWANT` for published messages, preventing redundant downloads of the same message received over gossip. This feature is opt-in and respects the existing `idontwant_message_size_threshold`. By default, `IDONTWANT` messages will only be sent for published messages larger than 1000 bytes. reference PRs: [spec](libp2p/specs#642) Pull-Request: libp2p#5773.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an optimisation to preemptively broadcast
IDONTWANTfor published messages, preventing redundant downloads of the same message received over gossip. This feature is opt-in and respects the existingidontwant_message_size_threshold. By default,IDONTWANTmessages will only be sent for published messages larger than 1000 bytes.reference PRs:
spec
Change checklist