Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added : demos to test ci #527

Merged
merged 1 commit into from
Mar 23, 2025
Merged

added : demos to test ci #527

merged 1 commit into from
Mar 23, 2025

Conversation

Khwahish29
Copy link
Contributor

@Khwahish29 Khwahish29 commented Mar 2, 2025

What was wrong?

Issue #513 showed that demos could break without triggering an alert during CI. This meant regressions could go unnoticed.

Issue #523

How was it fixed?

Added tests to verify that demos function correctly. If a demo breaks due to a change in the library, the CI will now fail, alerting developers to the issue.

Cute Animal Picture

put a cute animal picture link inside the parentheses

@Khwahish29 Khwahish29 marked this pull request as ready for review March 2, 2025 17:01
@pacrob
Copy link
Member

pacrob commented Mar 19, 2025

Hey, @Khwahish29, thanks for taking this! We no longer use CircleCI, so you'd need to add any new jobs into the existing github workflows (.github/workflows/tox.yml)

Otherwise looks good!

@Khwahish29
Copy link
Contributor Author

Hey, @Khwahish29, thanks for taking this! We no longer use CircleCI, so you'd need to add any new jobs into the existing github workflows (.github/workflows/tox.yml)

Otherwise looks good!

Done @pacrob ! Please have a look :)

@seetadev
Copy link

Hey, @Khwahish29, thanks for taking this! We no longer use CircleCI, so you'd need to add any new jobs into the existing github workflows (.github/workflows/tox.yml)
Otherwise looks good!

Done @pacrob ! Please have a look :)

@pacrob: All checks have passed successfully with the latest commit by @Khwahish29 . Please let me know your feedback.
PR looks ready to be merged.

@pacrob
Copy link
Member

pacrob commented Mar 22, 2025

Just wondering, @Khwahish29, why did you choose to exclude the demo checks for py3.12 and py3.13?

@Khwahish29
Copy link
Contributor Author

Just wondering, @Khwahish29, why did you choose to exclude the demo checks for py3.12 and py3.13?

yeah i did that while doing it locally, made the changes. its good to go now :)

@pacrob pacrob merged commit f6279c2 into libp2p:main Mar 23, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants