Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not expire self multiaddrs #3053

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

achingbrain
Copy link
Member

Do not apply address/record expiry to the peer store entry for the self peer.

Fixes #3051

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Do not apply address/record expiry to the peer store entry for the
self peer.

Fixes #3051
@achingbrain achingbrain requested a review from a team as a code owner March 18, 2025 14:03
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be clear, we don't expire self addresses, but updates do to network changes will update the addresses in the store, which will remove old invalid addresses, correct?

@achingbrain
Copy link
Member Author

Yes, the address manager updates the peer store record when listening addresses change.

@achingbrain achingbrain merged commit 2f2322a into main Mar 18, 2025
46 of 47 checks passed
@achingbrain achingbrain deleted the fix/do-not-expire-own-multiaddrs branch March 18, 2025 14:43
@achingbrain achingbrain mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PeerStore expires and evicts own self's peer data, breaking identify protocol
2 participants