fix: only check for non-wildcard ports #3050
Merged
+103
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are passed a wildcard port, start a UDP mux listener on a ephemeral port, otherwise check the existing listeners before trying to start a new one. To be reused an existing listener must be owned by the current peer and be of the other IP family (e.g. you cannot listen on `[ip4-host]:1234` twice but you can listen on `[ip4-host:1234]` and `[ip6-host]:1234`. Fixes #3049
2color
approved these changes
Mar 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are passed a wildcard port, start a UDP mux listener on a ephemeral port, otherwise check the existing listeners before trying to start a new one.
To be reused an existing listener must be owned by the current peer and be of the other IP family (e.g. you cannot listen on
[ip4-host]:1234twice but you can listen on[ip4-host:1234]and[ip6-host]:1234.Fixes #3049
Change checklist