Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement WebRTC certificate sotorage in the keychain #3048

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Crosstons
Copy link

@Crosstons Crosstons commented Mar 16, 2025

Title

feat: Implement WebRTC certificate persistence

Description

This PR implements the WebRTC certificate persistence functionality. The following changes have been made:

  • Added certificate-store.ts to handle storing and retrieving certificates from the keychain.
  • Created tests for certificate persistence in certificate-persistence.spec.ts.

This addresses the issue of ensuring certificates can be stored and reused across node restarts, improving the reliability and efficiency of WebRTC connections.

Related #2988.

Notes & open questions

  • The test file certificate-persistence.spec.ts contains two tests. One test passes successfully, while the second test related to persisting certificates between restarts still needs changes. Further debugging and adjustments are required to ensure all tests pass.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@Crosstons Crosstons requested a review from a team as a code owner March 16, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant