fix: #2902 #2903
Closed
fix: #2902 #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sacha Froment <[email protected]>
achingbrain
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Thanks for opening this PR - I'm going to merge #2904 instead but I wanted to add a quick note to the test here for future reference.
| @@ -9,13 +9,15 @@ import { multiaddr } from '@multiformats/multiaddr' | |||
| import { WebSockets, WebSocketsSecure } from '@multiformats/multiaddr-matcher' | |||
| import { expect } from 'aegir/chai' | |||
| import { isLoopbackAddr } from 'is-loopback-addr' | |||
| import { createLibp2p } from 'libp2p' | |||
There was a problem hiding this comment.
This module doesn't depend on libp2p but adding this test here would mean the dependency would need to be added.
This is intentional as it creates weird dependency loops that mean (among other things) a patch release of @libp2p/websockets would also cause a patch release of libp2p even if no changes were made there.
If you need to do integration-style testing, tests should be added to the integration-tests module, this won't cause any cascading releases.
|
Closing in favour of #2904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
[Fix ](fix: #2902)
Description
change the way the we call listen so that pubsubdisco can call the getAddresses
Notes & open questions
Detailed issue here #2902
(I don't think it's the good way of fixing this but I might be wrong)
Change checklist