tcpreuse: error on using tcpreuse with pnet #3129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharing the TCP Listen socket with WebSocket doesn't work with pnet.
aschmahmann
approved these changes
Dec 30, 2024
Comment on lines
+484
to
+486
| if len(cfg.PSK) > 0 && cfg.ShareTCPListener { | ||
| return nil, errors.New("cannot use shared TCP and WebSocket listener with PSK") | ||
| } |
There was a problem hiding this comment.
LGTM, although technically the shared listener feature isn't coupled to having TCP + WS since you can currently enable it with just TCP (albeit at no real benefit) and down the road it might be configurable with HTTP as well.
Comment on lines
+454
to
+455
| defer func() { | ||
| if createErr != nil { |
There was a problem hiding this comment.
Does this cover everything not already stopped by fx and how does this play with the closing that happens when autonat fails to start?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing the TCP Listen socket with WebSocket doesn't work with pnet.