tcp: fix metrics test build directive #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sukunrt Do we still need this PR? |
sukunrt
force-pushed
the
sukun/metrics-test-build-fix
branch
from
7f75024 to
3e28e8e
Compare
sukunrt
force-pushed
the
sukun/metrics-test-build-fix
branch
from
3e28e8e to
8810b8b
Compare
|
@p-shahi looks reasonable to me. Updated the description to explain the change. |
p-shahi
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test works on all platforms. It tests for transport correctness in case we have metrics enabled.
This removes the incorrect directive(whitespace in front of the name) and the platform specific file suffix.