webrtc: reuse port when dialing #2593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
changed the title
sukunrt
force-pushed
the
sukun/webrtc-reuseport
branch
3 times, most recently
from
d7adc59 to
fd2cc3d
Compare
sukunrt
force-pushed
the
sukun/webrtc-reuseport
branch
from
fd2cc3d to
c57e54c
Compare
sukunrt
force-pushed
the
sukun/webrtc-reuseport
branch
from
c57e54c to
9f660b1
Compare
Closed
|
This is not useful without further work. Even if we reuse port when dialing, we will not dial anyone with a /webrtc-direct address as we will always prefer QUIC to webrtc-direct. This means, it'll not help us much with address discovery. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #2586
fixes: #2592
The fix turned out much simpler that I'd expected. Reusing the udp mux for dialing is straightforward.
Here we only reuse the listening udpmux. If not listening, a new mux is created everytime we dial.
Adds certhashes to discovered /webrtc-direct addresses. Unfortunately this is impossible to unit test currently. I'll manually verify this for now. The situation is the same for webtransport.