Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm: wait for transient connections to upgrade for NewStream #2542

Merged
merged 3 commits into from
Oct 15, 2023
Merged

swarm: wait for transient connections to upgrade for NewStream #2542

merged 3 commits into from
Oct 15, 2023

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Aug 30, 2023 •
edited
Loading

depends on #2547, This PR is just the last commit. This might help to review it independently b2377e9

closes #1603

@sukunrt sukunrt force-pushed the sukun/swarm-relay-upgrade branch 5 times, most recently from ddefcea to 2d88d54 Compare September 1, 2023 08:22
@sukunrt sukunrt marked this pull request as ready for review September 1, 2023 09:17
@sukunrt sukunrt force-pushed the sukun/swarm-relay-upgrade branch from 2d88d54 to b2377e9 Compare September 1, 2023 09:25
marten-seemann
marten-seemann reviewed Sep 14, 2023
View reviewed changes
p2p/net/swarm/swarm.go Outdated Show resolved Hide resolved
p2p/net/swarm/swarm.go Show resolved Hide resolved
p2p/net/swarm/swarm.go Show resolved Hide resolved
p2p/net/swarm/swarm.go Outdated Show resolved Hide resolved
p2p/net/swarm/swarm.go Outdated Show resolved Hide resolved
p2p/net/swarm/swarm.go Show resolved Hide resolved
@sukunrt sukunrt force-pushed the sukun/swarm-relay-upgrade branch 2 times, most recently from 6a32bce to 9f86644 Compare September 18, 2023 05:38
@lidel lidel mentioned this pull request Sep 18, 2023
Closed
3 tasks
@sukunrt sukunrt mentioned this pull request Sep 18, 2023
Closed
@sukunrt sukunrt force-pushed the sukun/swarm-relay-upgrade branch from 9f86644 to 7d09432 Compare October 1, 2023 14:22
marten-seemann
marten-seemann approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Would be nice if there was a way to test this without sleeping for a second. Other than that, this lgtm. Feel free to merge any time.

p2p/test/basichost/basic_host_test.go Outdated Show resolved Hide resolved
p2p/test/swarm/swarm_test.go Outdated Show resolved Hide resolved
@p-shahi p-shahi mentioned this pull request Oct 13, 2023
Closed
25 tasks
@sukunrt sukunrt force-pushed the sukun/swarm-relay-upgrade branch from f09bc80 to e1d5728 Compare October 15, 2023 21:15
@sukunrt sukunrt merged commit 17a4649 into master Oct 15, 2023
@sukunrt sukunrt deleted the sukun/swarm-relay-upgrade branch October 15, 2023 22:13
sukunrt added a commit that referenced this pull request Oct 18, 2023
@sukunrt
swarm: wait for transient connections to upgrade for NewStream (#2542)
864f699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

@Jorropo Jorropo Awaiting requested review from Jorropo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect should wait for an acceptable connection
2 participants
@sukunrt @marten-seemann