Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Persistence Layer on top of PubSub #33
Add Persistence Layer on top of PubSub #33
Changes from 17 commits
43ebd02
f57d48c
e2a5fca
ff89016
90c980a
3ae7b1f
6fb9435
f3f8dd4
9e9d778
a24054d
092d0e1
3bf24fa
e9b0864
f85f2bc
9756263
a4d4d6c
97ac549
b0eeb77
4fbc97b
aa737d1
ded823d
76d8fca
1913974
fdbeaec
b303f91
0787cb5
41f6fb8
981b38c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably make
getLocal
part of the type, given its usage pattern.Also, better to typedef the function type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typedef 👍 (or an interface would also be fine)
part of the type 👎
If you'd prefer passing in an interface we can do that, but there's no reason to tie this to any particular implementation of "get stuff". We use a data store for this in the rest of this library, but data store has put + get, and we only need get.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to be part of the type i think...
no need for an interface, just a function typedef will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, although we'll need to revisit this if/when we expose this function publicly since an interface will likely be more appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now uses a version of libp2p/pubsub from master. However, there hasn't been a release yet so it's referencing
v0.1.1-0.20190807100218-9f04364996b4