Skip to content

fix(settings): show mDNS interval in seconds instead of milliseconds #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukyrys wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(settings): show mDNS interval in seconds instead of milliseconds #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions frontend/src/pages/Settings/SettingsDownload.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@
let autoRecovery = $state($autoErrorRecovery);
let autoConnectNetworks = $state($autoConnectNewNetworks);
let mdns = $state($mdnsEnabled);
let mdnsIntervalMs = $state($mdnsInterval.toString());
// UI exposes the interval in whole seconds; backend stores it in milliseconds.
let mdnsIntervalSec = $state(Math.round($mdnsInterval / 1000).toString());

// Browse functions
function openBrowse(type: 'storage' | 'temp' | 'lish' | 'lishnet' | 'backup'): void {
Expand Down Expand Up @@ -121,8 +122,9 @@
}

function saveMdnsInterval(): void {
setMdnsInterval(parseInt(mdnsIntervalMs) || 10000);
mdnsIntervalMs = $mdnsInterval.toString();
const seconds = parseInt(mdnsIntervalSec);
setMdnsInterval(Number.isFinite(seconds) && seconds > 0 ? seconds * 1000 : 10000);
mdnsIntervalSec = Math.round($mdnsInterval / 1000).toString();
}

function saveAll(): void {
Expand Down Expand Up @@ -240,7 +242,7 @@
}

function resetMdnsInterval(): void {
mdnsIntervalMs = String(settingsDefaults?.network?.mdnsInterval ?? 10000);
mdnsIntervalSec = String(Math.round((settingsDefaults?.network?.mdnsInterval ?? 10000) / 1000));
}

const navHandle = createNavArea(() => ({ areaID, position, onBack, activate: true }));
Expand Down Expand Up @@ -362,7 +364,7 @@
<SwitchRow label={$t('settings.download.mdnsEnabled') + ':'} checked={mdns} position={[0, 20]} onToggle={toggleMdns} />
</div>
<div class="row" role="group" data-mouse-activate-area={areaID}>
<Input bind:value={mdnsIntervalMs} label={$t('settings.download.mdnsInterval')} type="number" min={1000} position={[0, 21]} flex />
<Input bind:value={mdnsIntervalSec} label={$t('settings.download.mdnsInterval')} type="number" min={1} position={[0, 21]} flex />
<Button icon="/img/restart.svg" position={[1, 21]} onConfirm={resetMdnsInterval} padding="1vh" fontSize="4vh" borderRadius="1vh" width="6.6vh" height="6.6vh" />
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion frontend/static/langs/cs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@
"autoErrorRecovery": "Automatická obnova po chybě",
"autoConnectNewNetworks": "Po přidání nové sítě se k ní automaticky připojit",
"mdnsEnabled": "Vyhledávat účastníky v místní síti (mDNS)",
"mdnsInterval": "Interval vyhledávání v místní síti v ms"
"mdnsInterval": "Interval vyhledávání v místní síti (s)"
},
"lishNetwork": {
"title": "Síť LISH",
Expand Down
2 changes: 1 addition & 1 deletion frontend/static/langs/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@
"autoErrorRecovery": "Automatic error recovery",
"autoConnectNewNetworks": "Automatically connect to newly added networks",
"mdnsEnabled": "Discover peers on local network (mDNS)",
"mdnsInterval": "Local network discovery interval (ms)"
"mdnsInterval": "Local network discovery interval (s)"
},
"lishNetwork": {
"title": "LISH Network",
Expand Down