Start enforcing the Ruff ERA ruleset#266
Merged
Merged
Conversation
The ERA ruleset guards against commented-out Python code. There was one violation in a comment that described the default output of `sphinx-quickstart`, but its default behaviour has changed and in any case there is little reason to run `sphinx-quickstart` if the Sphinx configuration already exists, so the entire comment was safe to remove.
avalentino
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ERA ruleset guards against commented-out Python code. There is one violation in a comment that describes the default output of
sphinx-quickstart, but the default behavior has changed and in any case there is little reason to runsphinx-quickstartif the Sphinx configuration already exists.