Avoid needless local variables in Python wrappers#258
Merged
Conversation
The Python wrappers that can simply return the corresponding ufunc's return value (i.e. there is no status code to check and there are no new views) no longer store the ufunc's output in local variables, which makes them slightly faster.
avalentino
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python wrappers that can simply return the corresponding ufunc's return value no longer store the ufunc's output in local variables, which makes them slightly faster. For example, on current
mainbut with this PR
This does not affect any wrappers that have to check the status code the ufunc returns or that take new views of any of the returned arrays.