Move result tuple implementation from core.py template to erfa_generator#257
Merged
Conversation
Since 048f6ea (Use NamedTuple for functions with multiple outputs) if a Python wrapper returns a tuple then its elements can be accessed as named attributes. So far the implementation of that feature has been in the `core.py` template, but now the implementation is in `erfa_generator`, where it was possible to simplify it.
avalentino
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #176 if a Python wrapper returns a tuple then its elements can be accessed as named attributes. So far the implementation of that feature has been in the
core.pytemplate, but this PR moves a lot of the implementation to the newResultTupleclass inerfa_generator, where it can be simplified.This PR makes no changes to the
core.pyfileerfa_generatorcreates.