Fix PETSc 3.24 deprecated warnings

[jwpeterson]

I don't have PETSc 3.24 installed, so this is going to be coding via CI...

[jwpeterson]

Note: if this passes the "Test mac" target, we should be good. That is the only one that seems to be failing due to deprecation warnings (since -Werror is turned on).

[roystgnr]

we should be good.

Huh; I see someone has renamed the "Hubris check" recipe to "Min gcc". ;-)

[jwpeterson]

Well, this is interesting. The "Min gcc" build uses PETSc 3.22.1,

<<< Found PETSc 3.22.1 installation in /opt/petsc ... >>>

but for some reason it's reaching the #else clause of the code I just added:

../src/solvers/petsc_linear_solver.C: In member function 'virtual libMesh::LinearConvergenceReason libMesh::PetscLinearSolver<T>::get_converged_reason() const':
../src/solvers/petsc_linear_solver.C:780:10: error: 'KSP_CONVERGED_RTOL_NORMAL_EQUATIONS' was not declared in this scope
     case KSP_CONVERGED_RTOL_NORMAL_EQUATIONS : return CONVERGED_RTOL_NORMAL;
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/solvers/petsc_linear_solver.C:780:10: note: suggested alternative: 'KSP_CONVERGED_RTOL_NORMAL'
     case KSP_CONVERGED_RTOL_NORMAL_EQUATIONS : return CONVERGED_RTOL_NORMAL;
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          KSP_CONVERGED_RTOL_NORMAL
../src/solvers/petsc_linear_solver.C:781:10: error: 'KSP_CONVERGED_ATOL_NORMAL_EQUATIONS' was not declared in this scope
     case KSP_CONVERGED_ATOL_NORMAL_EQUATIONS : return CONVERGED_ATOL_NORMAL;
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/solvers/petsc_linear_solver.C:781:10: note: suggested alternative: 'KSP_CONVERGED_ATOL_NORMAL'
     case KSP_CONVERGED_ATOL_NORMAL_EQUATIONS : return CONVERGED_ATOL_NORMAL;
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          KSP_CONVERGED_ATOL_NORMAL

[jwpeterson]

That doesn't make any sense to me, unless something is wrong with our macro (that just calls the PETSc macro) in that version of PETSc?

#define PETSC_VERSION_LESS_THAN(major,minor,subminor) \
  PETSC_VERSION_LT(major,minor,subminor)

[moosebuild]

Job Coverage, step Generate coverage on aeeb8a7 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.