Verify PointLocator validity #4285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was useful in verifying for me that a potential downstream bug was just a red herring; it might be useful for others' debugging too.
This is expensive, but so is dbg in general; I don't think it's more much expensive than some of our existing tests.
|
Well, that swath of timeouts means so much for my "it'll be cheap enough to run in dbg mode" theory. |
|
Job Coverage, step Generate coverage on 76b0729 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was useful in verifying for me that a potential downstream bug was just a red herring; it might be useful for others' debugging too.
Actually running this after every construction is expensive, but so is dbg in general; I don't think it's more much expensive than some of our existing tests ... or even much more expensive than the PointLocatorTree construction, come to think of it.