Add embedded sharepoint, MCP23S17 driver and basic tests#5
Conversation
…unning make clean
Summary of ChangesHello @changxu-liu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly advances the embedded firmware development environment by integrating the 'Embedded-Sharepoint' project as a submodule and introducing a robust blocking driver for the MCP23S17 GPIO expander. The changes include a new Makefile for streamlined building, a reorganized project structure, and dedicated test cases to thoroughly verify the functionality of the MCP23S17 for input, output, and interrupt handling. These additions lay the groundwork for future hardware interaction and development. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new driver for the MCP23S17 SPI GPIO expander, along with a set of test applications and updates to the build system. However, a security audit identified two significant logic vulnerabilities in the MCP23S17 driver implementation: an incorrect hardware address calculation (address bits shifted left twice) and a type mismatch where the Chip Select pin is stored as an 8-bit integer, truncating STM32 GPIO pin bitmasks for pins 8 through 15. These can lead to unintended hardware behavior or denial of service. Additionally, the code contains critical bugs in the Makefile and driver logic, significant style and maintainability problems, unprofessional driver function names, performance concerns due to long, blocking delays, and bad practices in test code like modifying global strings and using magic numbers. Please address these issues to improve code quality and security.
Rav4s
left a comment
Rav4s
left a comment
There was a problem hiding this comment.
really nice job overall :)
i left comments throughout, let me know if you need clarifications. also address gemini comments and set up github actions for verifying compilation
changxu-liu
force-pushed
the
add_embedded_sharepoint
branch
from
cb697b0 to
9aaf389
Compare
changxu-liu
changed the title
Lakshay983
left a comment
Lakshay983
left a comment
There was a problem hiding this comment.
all your files in core in TestBoard_TPS27SA08-Q1 having that string appended to the names is kinda silly imo. Like is that not implied via the different folder?
…ion semaphore times out
3 participants
No description provided.