Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Feature: schedule lock #82

Closed
wants to merge 12 commits into from
Closed

Conversation

edrush
Copy link

@edrush edrush commented Dec 27, 2017

Closes #78.

Works fine for us. With this enhancement you can schedule the maintenance to start after a certain amount of time or at a special date time.

If you'd like to merge this but you want tests to be written (which I'd do if you want to merge) just tell me...

Best regards...

ps: also added slight updates (documentation, spelling, missing message, ...)

Wolfram Eberius and others added 12 commits December 7, 2017 15:39
Added support for 'startdate' and 'delay' options to lock command, added support for 'startdate' to driver 'Database'.
Store the optional ttl value temporary as integer to do the calculations later (as before start date/delay support).
* table and column identifiers have to be upper case
add support for Oracle database to database driver
@gilles-g
Copy link
Member

gilles-g commented Jan 5, 2018

Hi @edrush,

I think that feature is too much for that bundle, and too coupled with database.

Why did you need to schedule a maintenance? When you want to start a maintenance you are the developer and you know how and when to start it.

That bundle is just here to do a simple thing: lock and unlock.

We (lexik) wanted to do the same scheduler when we created this bundle, but nobody in our team needs to do that and doesn't want to do that, we need to have the control of what happen on our server, so we decided a scheduler was not a good idea.

But thx for your work :)

@gilles-g gilles-g closed this Jan 5, 2018
@edrush
Copy link
Author

edrush commented Jan 5, 2018

Hi @Spike31 ,

thanks for your answer. Our customer needs this to allow for informing his users about an upcoming lock (e.g. "In 30 minutes ..."). This way, the users have time to finish their work (I think I mentioned this already).

Alright. We will then go on working with and using our fork for our application. Hopefully we can merge your upcoming updates, but if not our schedule lock feature will be more important to us. Let's see, we'll try to stay compatible.

Thanks for your work, too!
Regards.

ps: In case you think about it again and want support for more drivers I could work on that, and the tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants