Improve English localisation #76
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakkamade
force-pushed
the
English
branch
7 times, most recently
from
2c499eb to
6a1cf4a
Compare
|
Please don't hesitate to speak up, if some strings are not to your liking. |
sakkamade
force-pushed
the
English
branch
7 times, most recently
from
cd8c3a6 to
2133153
Compare
sakkamade
force-pushed
the
English
branch
2 times, most recently
from
d3ec47d to
c268264
Compare
sakkamade
commented
Jul 19, 2021
| @@ -226,11 +226,11 @@ | |||
|
|
|||
| "_load_temporary_plugin": "Load temporary plugin", | |||
|
|
|||
| "_reload_theme": "Reload Theme", | |||
| "_reload_theme": "Reload theme", | |||
There was a problem hiding this comment.
I see you adding new strings capitalised, but vocabulary should be unified.
And since this way is more common, and is better, I am making such changes.
Please feel free to speak if you want to leave them as they are.
sakkamade
commented
Jul 19, 2021
src/locales/en/messages.json
Outdated
| @@ -155,9 +155,9 @@ | |||
|
|
|||
| "_manga": "Manga", | |||
|
|
|||
| "_jobs": "Jobs", | |||
| "_jobs": "Tasks ", | |||
There was a problem hiding this comment.
The space here was added intentionally, however it is better not to be added here, but there:
I will correct it.
There was a problem hiding this comment.
@leoding86, Or perhaps it will look superfluous in Chinese locale, so it is better to left the space here?
sakkamade
force-pushed
the
English
branch
3 times, most recently
from
d55139c to
d539100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimised
I have checked it mostly, and the only issue that I found is here:
This is how it looks without this commit:
Sorry, I don't really know JS, however I expect that adding something likeword-break: break-word;in case with CSS to corresponding file should fix it.EDIT: And so I did just that:
pixiv-omina/src/renderer/styles/app.scss
Line 91 in cc11dcf