feat: add lost grace discovered support #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the Elden Ring GitHub extension by adding support for multiple celebration sound effects, giving users more customization options for their GitHub PR celebrations. Users can now choose between the classic "You Died" sound and the new "Lost Grace Discovered" sound effect.
Key Changes
lost-grace-discovered.mp3as an alternative celebration soundelden_ring_sound.mp3toyou-die-sound.mp3for clearer naming conventionEldenRingSettingsinterface to includesoundTypepropertyType of Change
Test Plan
Manual Testing
Automated Testing
Breaking Changes
None
Note: While
elden_ring_sound.mp3was renamed toyou-die-sound.mp3, this is an internal asset change and does not affect users. The extension handles this transparently by defaulting to 'you-die-sound' for existing installations.Checklist