refactor: extract feature handlers

src/content/approveHandler.ts

@@ -0,0 +1,76 @@
+import { ShowSettings } from './showSettings';
+import { isPullRequestPage } from './pageUtils';
+
+export interface ApprovalSuccessOptions {
+  showSettings: ShowSettings;
+  onApproved: () => void;
+}
+
+export interface ApprovalButtonOptions {
+  showSettings: ShowSettings;
+}
+
+export const checkForPRApprovalSuccess = (options: ApprovalSuccessOptions): void => {
+  if (!isPullRequestPage()) return;
+
+  chrome.storage.local.get(['prApprovalTriggered', 'prApprovalTime'], (result) => {
+    if (result.prApprovalTriggered && result.prApprovalTime) {
+      const timeDiff = Date.now() - result.prApprovalTime;
+      if (timeDiff < 30000 && options.showSettings.isEnabled('approved')) {
+        console.log('✅ PR approval detected via storage flag, showing banner');
+        options.onApproved();
+        chrome.storage.local.remove(['prApprovalTriggered', 'prApprovalTime']);
+      } else if (timeDiff < 30000 && !options.showSettings.isEnabled('approved')) {
+        console.log('🚫 PR approval detected but disabled in settings');
+        chrome.storage.local.remove(['prApprovalTriggered', 'prApprovalTime']);
+      }
+    }
+  });
+};
+
+export const detectPRApprovalButtons = (options: ApprovalButtonOptions): void => {
+  if (!isPullRequestPage()) {
+    return;
+  }
+
+  const dialogElement = document.querySelector('div[role="dialog"]');
+  if (dialogElement) {
+    const buttons = Array.from(dialogElement.querySelectorAll('button'));
+    const submitButton = buttons.find((button) =>
+      button.textContent?.toLowerCase().includes('submit review'),
+    );
+
+    if (submitButton && !submitButton.hasAttribute('data-elden-ring-approval-listener')) {
+      submitButton.addEventListener('click', () => {
+        const approveRadio = dialogElement.querySelector(
+          'input[name="reviewEvent"][value="approve"]',
+        ) as HTMLInputElement;
+
+        if (approveRadio && approveRadio.checked) {
+          if (options.showSettings.isEnabled('approved')) {
+            console.log('🎯 Submit review with approval selected');
+            chrome.storage.local.set({
+              prApprovalTriggered: true,
+              prApprovalTime: Date.now(),
+            });
+          } else {
+            console.log('🚫 PR approval banner disabled in settings');
+          }
+        }
+      });
+      submitButton.setAttribute('data-elden-ring-approval-listener', 'true');
+    }
+  }
+
+  const approveRadios = document.querySelectorAll('input[name="reviewEvent"][value="approve"]');
+  approveRadios.forEach((radio) => {
+    if (!radio.hasAttribute('data-elden-ring-approval-listener')) {
+      radio.addEventListener('change', () => {
+        if ((radio as HTMLInputElement).checked) {
+          console.log('🎯 Approve option selected');
+        }
+      });
+      radio.setAttribute('data-elden-ring-approval-listener', 'true');
+    }
+  });
+};

src/content/closeHandler.ts

@@ -0,0 +1,34 @@
+import { ShowSettings } from './showSettings';
+import { isPullRequestPage } from './pageUtils';
+import { waitForCloseComplete } from './closeWatcher';
+
+export interface CloseHandlerOptions {
+  showSettings: ShowSettings;
+  onClosed: () => void;
+}
+
+export const detectCloseButtons = (options: CloseHandlerOptions): void => {
+  if (!isPullRequestPage() || !options.showSettings.isEnabled('closed')) {
+    return;
+  }
+
+  const closeButtonContainer = document.querySelector('#partial-new-comment-form-actions');
+  if (!closeButtonContainer) {
+    return;
+  }
+
+  const closeButtons = closeButtonContainer.querySelectorAll('button');
+  closeButtons.forEach((button) => {
+    const buttonText = button.textContent?.toLowerCase().trim() || '';
+    if (
+      buttonText.includes('close pull request') &&
+      !button.hasAttribute('data-elden-ring-close-listener')
+    ) {
+      button.addEventListener('click', () => {
+        console.log('🛑 Close pull request button clicked');
+        waitForCloseComplete(() => options.onClosed());
+      });
+      button.setAttribute('data-elden-ring-close-listener', 'true');
+    }
+  });
+};

src/content/content.test.ts

@@ -37,7 +37,7 @@ afterEach(() => {
   document.body.innerHTML = '';
 });
 
-describe('EldenRingMerger', () => {
+describe('EldenRingOrchestrator', () => {
   it('should call storage API for loading settings', () => {
     // Simulate the loadSettings method behavior
     chrome.storage.sync.get(['soundEnabled', 'showOnPRMerged', 'showOnPRCreate'], () => {});