Add Atlas Cloud provider - #194
Open
binyangzhu000-sudo wants to merge 1 commit into
Open
Conversation
saschabuehrle
requested changes
Aug 6, 2026
saschabuehrle
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the compact OpenAI-compatible provider implementation. The endpoint matches Atlas Cloud’s current official docs and the isolated tests, Ruff, and Black pass, but two runtime integration blockers remain.
Required before merge:
- Register
atlascloudinModelConfig.validate_providerandPROVIDER_CAPABILITIES. TodayModelConfig(name="x", provider="atlascloud", cost=0)raises a validation error, so aCascadeAgentcannot configure it. - Fix provider attribution inherited from
OpenAIProvider. A mocked successful request correctly callshttps://api.atlascloud.ai/v1/chat/completionsbut returnsModelResponse.provider == "openai"; inherited errors also identify OpenAI. This breaks provider telemetry and routing traces. - Fix or explicitly define cost behavior. Current
_get_litellm_prefix()producesopenai/qwen/qwen3.5-flash, which LiteLLM rejects before falling back to inherited OpenAI estimates. Add Atlas-aware estimation/capability semantics and tests. - Add an end-to-end provider test covering ModelConfig/registry resolution plus response attribution, not only constructor registration.
Please update against current main and re-request review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atlascloudin the provider registry and LiteLLM prefix mappingValidation
python3 -m pytest -o addopts='' tests/test_atlascloud.py tests/test_agent_module_callable.py -qpython3 -m compileall cascadeflow/providers/atlascloud.py cascadeflow/providers/__init__.py cascadeflow/providers/base.py tests/test_atlascloud.pygit diff --checkqwen/qwen3.5-flashanddeepseek-ai/deepseek-v4-proNotes: local environment does not have
rufforblackinstalled, so those checks could not be run here.README: no README changes; docs update only, no sponsor/logo/credits/partner promotion.