Skip to content

fix(macos): package whisper Metal dylibs with portable rpath#4

Merged
iswaryaalex merged 1 commit into
lemonade-sdk:masterfrom
fl0rianr:fl0rianr/improve_whisper_build
Jun 19, 2026
Merged

fix(macos): package whisper Metal dylibs with portable rpath#4
iswaryaalex merged 1 commit into
lemonade-sdk:masterfrom
fl0rianr:fl0rianr/improve_whisper_build

Conversation

@fl0rianr

Copy link
Copy Markdown

Fixes the macOS Metal whisper-server release package so it includes the required .dylib dependencies and uses a portable @loader_path rpath.

Why

Downstream Lemonade CI fails before Metal initialization because dyld cannot load @rpath/libwhisper.1.dylib from the extracted macOS Metal artifact.

Changes

  • Adds portable macOS rpath settings for the Metal build.
  • Packages generated .dylib files alongside whisper-cli and whisper-server.
  • Rewrites build-path dylib references to @rpath/.
  • Adds validation to fail packaging if whisper-server still references non-portable build paths or if libwhisper*.dylib is missing.

Test plan

  • GitHub Actions macOS Metal build/package job should pass.
  • Packaged whisper-server should no longer fail with Library not loaded: @rpath/libwhisper.1.dylib.

@Geramy Geramy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessss!!!! This is it!

@iswaryaalex

Copy link
Copy Markdown
Collaborator

Ah! Thank you.. Triggering Release after CI checks

@iswaryaalex iswaryaalex merged commit 184cab6 into lemonade-sdk:master Jun 19, 2026
22 checks passed
@fl0rianr fl0rianr deleted the fl0rianr/improve_whisper_build branch June 19, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants