build: keep the actual clang-<major> when trimming LLVM (clang-23 was deleted)#17
Open
liminfei-amd wants to merge 1 commit into
Open
Conversation
…d 22)
The LLVM-trim step kept only `clang` and `clang-22`, but the bundled LLVM is
major 23 (lib/clang/23, libclang-cpp.so.23). The `clang` driver re-execs
`clang-23`, which the keep-list did not match, so it was deleted — the shipped
bundle has the `clang` driver but no `clang-23`, and Triton's JIT fails with
"could not exec .../clang-23".
Derive the major from the resource dir `lib/clang/<major>` (fallback to
`clang -dumpversion`) and keep `clang-${major}` plus its cuda_wrappers path,
so this stays correct across LLVM bumps.
Confirmed on the released vllm0.22.1-rocm7.13.0-gfx1151 bundle: clang-23 absent,
JIT fails; supplying a system clang lets it compile. Not re-run through the full
build CI by me — this repo's PR build + gfx1151 qualification can confirm the
rebuilt bundle keeps clang-23 and that Triton-based inference passes. See lemonade-sdk#16.
Signed-off-by: liminfei-amd <91481003+liminfei-amd@users.noreply.github.com>
liminfei-amd
added a commit
to liminfei-amd/vllm-rocm
that referenced
this pull request
Jun 15, 2026
liminfei-amd
added a commit
to liminfei-amd/vllm-rocm
that referenced
this pull request
Jun 15, 2026
…proven on real AMD bundle: clang-23 survives)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16.
What
The "Trim LLVM toolchain" step kept only
clangand a hardcodedclang-22, but the bundled LLVM is major 23. Theclangdriver re-execsclang-23, which the keep-list didn't match — soclang-23was deleted. The shipped bundle has theclangdriver but noclang-23, and Triton's JIT fails withcould not exec .../clang-23.Change
Derive the LLVM major from the resource dir
lib/clang/<major>(fallbackclang -dumpversion) and keepclang-${major}+ itscuda_wrapperspath, instead of hardcoding22. Stays correct across LLVM bumps.Evidence
On the released
vllm0.22.1-rocm7.13.0-gfx1151bundle:bin/clang-23is absent (only the 26 KBclangdriver),lib/clang/23/+libclang-cpp.so.23are present, andclang --versionerrors withcould not exec .../clang-23. Triton JIT then fails; supplying a system clang lets it compile.Verification (honest)
I did not re-run the full build CI myself. This repo's
pull_requestbuild + the gfx1151 qualification (tier2 inference uses Triton) are the right place to confirm the rebuilt bundle keepsclang-23and that Triton-based inference passes. Opening as draft for that reason and for maintainer review of the approach.AI usage disclosure: this change was prepared with AI assistance; a human reviewed and verified it and can explain every line. Verified: missing-binary + JIT failure reproduced on the released bundle.