Fix: flaky Whisper realtime transcription event handling#2535
Merged
Conversation
Accumulate realtime transcription deltas instead of relying only on the completed event transcript field. Some backends/SDK event shapes can deliver text via delta events while completed marks the final state with an empty transcript, causing a false negative despite successful transcription. Also make realtime event field access robust for SDK objects and dict-like events.
github-actions
Bot
added
bug
Member
|
@Geramy can you review? It would improve the stability of macOS CI testing quite a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky Whisper realtime WebSocket transcription test where the server
emitted conversation.item.input_audio_transcription.delta and
completedevents, but the test only asserted text from
completed.transcript.The test now accumulates transcript text from delta events and falls back to the
completed transcript when present. Event field access is also made robust for
OpenAI SDK event objects and dict-like events.
commit test behavior