Create the default C-x keymap. #1955
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates the lem-core:*global-prefix-keymap* and binds to it "C-x". This allows users to rebind the keymap to a different prefix. New "C-x" bindings in the lem-core:*global-keymap* should be bound in this new keymap instead.
Collaborator
|
That sounds great, thank you. Does that break backward compatibility with existing "C-x …" bindings to the global keymap in one's init file? (I guess not?) Can you also send a PR to the documentation on https://github.com/lem-project/lem-project.github.io/ too ? Thanks! |
Author
|
After doing some more testing there is an issue if there is an "C-x" binding in the init file. I'll see if I can get that resolved and then I'll update the documentation too. |
Collaborator
|
if you threw a good, understantable error message that would help users migrate, that would be good too. if both options are too difficult, alright. |
Collaborator
|
hey @sethaldini , what's up with this good PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates the
lem-core:*global-prefix-keymap*and binds to it "C-x". This allows users to rebind the keymap to a different prefix. New "C-x" bindings in thelem-core:*global-keymap*should be bound in this new keymap instead.