Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display meeting location on the full screen overlay #774

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

casvanluijtelaar
Copy link
Contributor

Status

READY

Description

We have a lot of people that are very excited for this project. But the problem is we work in a big office with a lot of meeting rooms. so every time I get the meeting popup, I still have to look at my calendar to see where I am supposed to be going.

Looking at the Google Calendar API, you are already including the right field, you are just not using it yet. this PR fixes that!

Checklist

Steps to Test or Reproduce

configure a room/location on your google calendar meeting. when the full screen popup appears, it will now also diplsay the location.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. feature New feature or request labels Nov 8, 2024
MeetingBar/Views/FullscreenNotification.swift Dismissed Show dismissed Hide dismissed
MeetingBar/Views/FullscreenNotification.swift Dismissed Show dismissed Hide dismissed
@tomo-umain
Copy link

very useful, thanks!

@alsedi
Copy link

alsedi commented Nov 8, 2024

truly good

Copy link
Owner

@leits leits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 18, 2024
@leits leits merged commit f6e660c into leits:master Nov 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants