Skip to content

feat(jupyterhub-more): install glab package - #86

Open
dclong wants to merge 8 commits into
mainfrom
dev
Open

feat(jupyterhub-more): install glab package#86
dclong wants to merge 8 commits into
mainfrom
dev

Conversation

@dclong

@dclong dclong commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • feat(jupyterhub-more): install glab package

Changed files

Modified

  • jupyterhub-more/Containerfile (+1/-1)

Commits

@dclong

dclong commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Claude finished @dclong's task in 15s —— View job

Code review

  • Reviewed the diff (jupyterhub-more/Containerfile, +1/-1)

The change adds glab to the existing dnf install line next to gh. The line is still inside the same RUN layer, so it is followed by purge_cache.sh as before.

I found no correctness bugs or blocking issues. I could not build the image here. The one assumption is that glab is available in the base image's dnf repos. It is packaged in Fedora, and gh is already installed the same way, so I expect it to be.

AUTO_MERGE_APPROVED

dclong and others added 2 commits October 11, 2026 20:53
@dclong
fix(jupyterhub-more): stop setting CARGO_HOME to the root-owned /usr/…
8cca9db 
…local/cargo

Commit a59d81c added CARGO_HOME=/usr/local/cargo to the Rust kernel ENV.
That directory is owned by root, so `cargo build` run as a regular user
in jupyterhub-more and the images built from it (jupyterhub-ds,
vscode-server, codespaces) fails with "Permission denied" when cargo
tries to create its registry cache there.

Nothing in these images needs the variable: the build never runs cargo
and only copies /usr/local/cargo/bin and /usr/local/rustup from
rust-utils. The rustup proxies find toolchains through RUSTUP_HOME. With
CARGO_HOME unset, cargo goes back to the per-user default ~/.cargo, as
it did before a59d81c. rust-cicd/Containerfile already works this way.
@dclong
Merge pull request #87 from legendu-net/push-sopmusrqxtzl
8a129a1 
fix(jupyterhub-more): stop setting CARGO_HOME to the root-owned /usr/local/cargo
@dclong

dclong commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Claude finished @dclong's task in 12s —— View job

Code review

1. gh glab. This adds glab to the existing dnf install line, in the same RUN layer. purge_cache.sh still runs after it. glab is packaged in Fedora and gh is installed the same way, so I expect it to resolve. I couldn't build the image here, so that is unverified.

2. Removing CARGO_HOME=/usr/local/cargo. The ENV line now sets only RUSTUP_HOME and PATH. PATH still includes /usr/local/cargo/bin, so the rustup proxy binaries stay reachable. Cargo's home now defaults to the running user's ~/.cargo, which is writable. That fixes the root-owned directory problem the commit message describes.

I found no correctness bugs or blocking issues.

AUTO_MERGE_APPROVED

runner and others added 2 commits October 14, 2026 16:40
@dclong

dclong commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Claude finished @dclong's task in 14s —— View job

Code review

1. glab install (jupyterhub-more/Containerfile). glab is added to the existing dnf install line next to gh, in the same RUN layer. purge_cache.sh still runs after it. glab is packaged in Fedora, so I expect it to resolve. I couldn't build the image here, so that is unverified.

2. Removing CARGO_HOME=/usr/local/cargo (jupyterhub-more/Containerfile). The ENV line now sets only RUSTUP_HOME and PATH. PATH still includes /usr/local/cargo/bin, so the rustup proxy binaries stay reachable. Cargo's home now defaults to the running user's ~/.cargo, which is writable.

3. jupyterhub pip pins (jupyterhub/Containerfile). The SQLAlchemy<2.0.0 pin is dropped, and jupyterhub<6.0.0 becomes jupyterhub<6.1.0. As far as I know, JupyterHub 5.x supports SQLAlchemy 2, so dropping the pin should be fine. Again, I couldn't build or run it here.

I found no correctness bugs or blocking issues.

AUTO_MERGE_APPROVED

@dclong

dclong commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Claude encountered an error after 0s —— View job

I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dclong